2021-02-02 10:20:49

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables

Fix the following coccicheck warnings:

./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is
equivalent to !A || B.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/xen-netfront.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index b01848e..5158841 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1813,7 +1813,7 @@ static int setup_netfront(struct xenbus_device *dev,
* a) feature-split-event-channels == 0
* b) feature-split-event-channels == 1 but failed to setup
*/
- if (!feature_split_evtchn || (feature_split_evtchn && err))
+ if (!feature_split_evtchn || err)
err = setup_netfront_single(queue);

if (err)
--
1.8.3.1


2021-02-04 11:13:01

by Jürgen Groß

[permalink] [raw]
Subject: Re: [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables

On 02.02.21 11:17, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is
> equivalent to !A || B.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Reviewed-by: Juergen Gross <[email protected]>


Juergen


Attachments:
OpenPGP_0xB0DE9DD628BF132F.asc (3.06 kB)
OpenPGP_signature (505.00 B)
OpenPGP digital signature
Download all attachments

2021-02-05 01:44:47

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 2 Feb 2021 18:17:49 +0800 you wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is
> equivalent to !A || B.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
>
> [...]

Here is the summary with links:
- drivers: net: xen-netfront: Simplify the calculation of variables
https://git.kernel.org/netdev/net-next/c/e93fac3b5161

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html