2021-02-07 08:55:40

by Jinyang He

Subject: [PATCH] MIPS: process: Fix no previous prototype warning

unwind_stack_by_address and unwind_stack need <asm/stacktrace.h>.
arch_align_stack needs <asm/exec.h>

link: https://lists.01.org/hyperkitty/list/[email protected]/thread/ZPL2RRA6RZKRQZI5IGOVLFXN2GVZBN3L/
Fixes: ("MIPS: process: Remove unnecessary headers inclusion")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Jinyang He <[email protected]>
---
arch/mips/kernel/process.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
index 0c5bc06..2e591df 100644
--- a/arch/mips/kernel/process.c
+++ b/arch/mips/kernel/process.c
@@ -26,6 +26,7 @@
#include <asm/asm.h>
#include <asm/dsemul.h>
#include <asm/dsp.h>
+#include <asm/exec.h>
#include <asm/fpu.h>
#include <asm/inst.h>
#include <asm/irq.h>
@@ -36,6 +37,7 @@
#include <asm/mipsregs.h>
#include <asm/processor.h>
#include <asm/reg.h>
+#include <asm/stacktrace.h>

#ifdef CONFIG_HOTPLUG_CPU
void arch_cpu_idle_dead(void)
--
2.1.0

2021-02-09 12:43:12

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: process: Fix no previous prototype warning

On Sun, Feb 07, 2021 at 04:52:36PM +0800, Jinyang He wrote:
> unwind_stack_by_address and unwind_stack need <asm/stacktrace.h>.
> arch_align_stack needs <asm/exec.h>
>
> link: https://lists.01.org/hyperkitty/list/[email protected]/thread/ZPL2RRA6RZKRQZI5IGOVLFXN2GVZBN3L/
> Fixes: ("MIPS: process: Remove unnecessary headers inclusion")

this Fixes is broken, it's missing a git hash. But there is no reason
for a fixes tag, because it "only" removed a warning, but doesn't fix
a bug. So I've removed it while applying the patch.

> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Jinyang He <[email protected]>
> ---
> arch/mips/kernel/process.c | 2 ++
> 1 file changed, 2 insertions(+)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]