2021-02-07 11:44:49

by Xiaofei Tan

[permalink] [raw]
Subject: [PATCH for-next 14/32] scsi: ibmvscsi: Replace spin_lock_irqsave with spin_lock in hard IRQ

It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <[email protected]>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 755313b..9afe1b2 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -3604,12 +3604,11 @@ static struct ibmvfc_crq *ibmvfc_next_crq(struct ibmvfc_host *vhost)
static irqreturn_t ibmvfc_interrupt(int irq, void *dev_instance)
{
struct ibmvfc_host *vhost = (struct ibmvfc_host *)dev_instance;
- unsigned long flags;

- spin_lock_irqsave(vhost->host->host_lock, flags);
+ spin_lock(vhost->host->host_lock);
vio_disable_interrupts(to_vio_dev(vhost->dev));
tasklet_schedule(&vhost->tasklet);
- spin_unlock_irqrestore(vhost->host->host_lock, flags);
+ spin_unlock(vhost->host->host_lock);
return IRQ_HANDLED;
}

--
2.8.1