2021-02-07 18:41:42

by Stefan Chulski

Subject: [PATCH v9 net-next 01/15] doc: marvell: add CM3 address space and PPv2.3 description

From: Stefan Chulski <[email protected]>

Patch adds CM3 address space PPv2.3 description.

Signed-off-by: Stefan Chulski <[email protected]>
---
Documentation/devicetree/bindings/net/marvell-pp2.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/marvell-pp2.txt b/Documentation/devicetree/bindings/net/marvell-pp2.txt
index b783976..1eb480a 100644
--- a/Documentation/devicetree/bindings/net/marvell-pp2.txt
+++ b/Documentation/devicetree/bindings/net/marvell-pp2.txt
@@ -1,5 +1,6 @@
* Marvell Armada 375 Ethernet Controller (PPv2.1)
Marvell Armada 7K/8K Ethernet Controller (PPv2.2)
+ Marvell CN913X Ethernet Controller (PPv2.3)

Required properties:

@@ -12,7 +13,7 @@ Required properties:
- common controller registers
- LMS registers
- one register area per Ethernet port
- For "marvell,armada-7k-pp2", must contain the following register
+ For "marvell,armada-7k-pp2" used by 7K/8K and CN913X, must contain the following register
sets:
- packet processor registers
- networking interfaces registers
@@ -81,7 +82,7 @@ Example for marvell,armada-7k-pp2:

cpm_ethernet: ethernet@0 {
compatible = "marvell,armada-7k-pp22";
- reg = <0x0 0x100000>, <0x129000 0xb000>;
+ reg = <0x0 0x100000>, <0x129000 0xb000>, <0x220000 0x800>;
clocks = <&cpm_syscon0 1 3>, <&cpm_syscon0 1 9>,
<&cpm_syscon0 1 5>, <&cpm_syscon0 1 6>, <&cpm_syscon0 1 18>;
clock-names = "pp_clk", "gop_clk", "mg_clk", "mg_core_clk", "axi_clk";
--
1.9.1

2021-02-07 21:33:58

by Andrew Lunn

Subject: Re: [PATCH v9 net-next 01/15] doc: marvell: add CM3 address space and PPv2.3 description

On Sun, Feb 07, 2021 at 08:38:43PM +0200, [email protected] wrote:
> From: Stefan Chulski <[email protected]>
>
> Patch adds CM3 address space PPv2.3 description.
>
> Signed-off-by: Stefan Chulski <[email protected]>
> ---
> Documentation/devicetree/bindings/net/marvell-pp2.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/marvell-pp2.txt b/Documentation/devicetree/bindings/net/marvell-pp2.txt
> index b783976..1eb480a 100644
> --- a/Documentation/devicetree/bindings/net/marvell-pp2.txt
> +++ b/Documentation/devicetree/bindings/net/marvell-pp2.txt
> @@ -1,5 +1,6 @@
> * Marvell Armada 375 Ethernet Controller (PPv2.1)
> Marvell Armada 7K/8K Ethernet Controller (PPv2.2)
> + Marvell CN913X Ethernet Controller (PPv2.3)
>
> Required properties:
>
> @@ -12,7 +13,7 @@ Required properties:
> - common controller registers
> - LMS registers
> - one register area per Ethernet port
> - For "marvell,armada-7k-pp2", must contain the following register
> + For "marvell,armada-7k-pp2" used by 7K/8K and CN913X, must contain the following register
> sets:
> - packet processor registers
> - networking interfaces registers

Hi Stefan

Shouldn't there be an entry here describing what the third register
set is?

2021-02-07 23:41:08

by Stefan Chulski

Subject: RE: [EXT] Re: [PATCH v9 net-next 01/15] doc: marvell: add CM3 address space and PPv2.3 description

> > @@ -12,7 +13,7 @@ Required properties:
> > - common controller registers
> > - LMS registers
> > - one register area per Ethernet port
> > - For "marvell,armada-7k-pp2", must contain the following register
> > + For "marvell,armada-7k-pp2" used by 7K/8K and CN913X, must contain
> > + the following register
> > sets:
> > - packet processor registers
> > - networking interfaces registers
>
> Hi Stefan
>
> Shouldn't there be an entry here describing what the third register set is?

Would add it in next patchset.

Thanks,
Stefan.