2021-02-08 10:38:17

by Yang Li

Subject: [PATCH] selftests/ipc: remove unneeded semicolon

Eliminate the following coccicheck warning:
./tools/testing/selftests/ipc/msgque.c:72:3-4: Unneeded semicolon
./tools/testing/selftests/ipc/msgque.c:183:2-3: Unneeded semicolon
./tools/testing/selftests/ipc/msgque.c:191:2-3: Unneeded semicolon

Signed-off-by: Yang Li <[email protected]>
---
tools/testing/selftests/ipc/msgque.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
index 5ec4d9e..656c43c 100644
--- a/tools/testing/selftests/ipc/msgque.c
+++ b/tools/testing/selftests/ipc/msgque.c
@@ -69,7 +69,7 @@ int restore_queue(struct msgque_data *msgque)
printf("msgsnd failed (%m)\n");
ret = -errno;
goto destroy;
- };
+ }
}
return 0;

@@ -180,7 +180,7 @@ int fill_msgque(struct msgque_data *msgque)
IPC_NOWAIT) != 0) {
printf("First message send failed (%m)\n");
return -errno;
- };
+ }

msgbuf.mtype = ANOTHER_MSG_TYPE;
memcpy(msgbuf.mtext, ANOTHER_TEST_STRING, sizeof(ANOTHER_TEST_STRING));
@@ -188,7 +188,7 @@ int fill_msgque(struct msgque_data *msgque)
IPC_NOWAIT) != 0) {
printf("Second message send failed (%m)\n");
return -errno;
- };
+ }
return 0;
}

--
1.8.3.1

2021-02-08 23:36:31

by Shuah Khan

Subject: Re: [PATCH] selftests/ipc: remove unneeded semicolon

On 2/8/21 3:24 AM, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./tools/testing/selftests/ipc/msgque.c:72:3-4: Unneeded semicolon
> ./tools/testing/selftests/ipc/msgque.c:183:2-3: Unneeded semicolon
> ./tools/testing/selftests/ipc/msgque.c:191:2-3: Unneeded semicolon
>
> Signed-off-by: Yang Li <[email protected]>
> ---
> tools/testing/selftests/ipc/msgque.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
> index 5ec4d9e..656c43c 100644
> --- a/tools/testing/selftests/ipc/msgque.c
> +++ b/tools/testing/selftests/ipc/msgque.c
> @@ -69,7 +69,7 @@ int restore_queue(struct msgque_data *msgque)
> printf("msgsnd failed (%m)\n");
> ret = -errno;
> goto destroy;
> - };
> + }
> }
> return 0;
>
> @@ -180,7 +180,7 @@ int fill_msgque(struct msgque_data *msgque)
> IPC_NOWAIT) != 0) {
> printf("First message send failed (%m)\n");
> return -errno;
> - };
> + }
>
> msgbuf.mtype = ANOTHER_MSG_TYPE;
> memcpy(msgbuf.mtext, ANOTHER_TEST_STRING, sizeof(ANOTHER_TEST_STRING));
> @@ -188,7 +188,7 @@ int fill_msgque(struct msgque_data *msgque)
> IPC_NOWAIT) != 0) {
> printf("Second message send failed (%m)\n");
> return -errno;
> - };
> + }
> return 0;
> }
>
>

Thank you. Now applied to linux-kselftest next for 5.12-rc1

thanks,
-- Shuah