2021-02-10 09:42:23

by Jiapeng Chong

Subject: [PATCH] DMA/qedr: Use true and false for bool variable

Fix the following coccicheck warning:

./drivers/infiniband/hw/qedr/qedr.h:629:9-10: WARNING: return of 0/1 in
function 'qedr_qp_has_rq' with return type bool.

./drivers/infiniband/hw/qedr/qedr.h:620:9-10: WARNING: return of 0/1 in
function 'qedr_qp_has_sq' with return type bool.

Reported-by: Abaci Robot<[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/infiniband/hw/qedr/qedr.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/qedr/qedr.h b/drivers/infiniband/hw/qedr/qedr.h
index 9dde703..3cb4feb 100644
--- a/drivers/infiniband/hw/qedr/qedr.h
+++ b/drivers/infiniband/hw/qedr/qedr.h
@@ -617,18 +617,18 @@ static inline bool qedr_qp_has_srq(struct qedr_qp *qp)
static inline bool qedr_qp_has_sq(struct qedr_qp *qp)
{
if (qp->qp_type == IB_QPT_GSI || qp->qp_type == IB_QPT_XRC_TGT)
- return 0;
+ return false;

- return 1;
+ return true;
}

static inline bool qedr_qp_has_rq(struct qedr_qp *qp)
{
if (qp->qp_type == IB_QPT_GSI || qp->qp_type == IB_QPT_XRC_INI ||
qp->qp_type == IB_QPT_XRC_TGT || qedr_qp_has_srq(qp))
- return 0;
+ return false;

- return 1;
+ return true;
}

static inline struct qedr_user_mmap_entry *
--
1.8.3.1

2021-02-10 10:01:07

by Michal Kalderon

Subject: RE: [EXT] [PATCH] DMA/qedr: Use true and false for bool variable

> From: Jiapeng Chong <[email protected]>
> Sent: Wednesday, February 10, 2021 11:38 AM
>
> ----------------------------------------------------------------------
> Fix the following coccicheck warning:
>
> ./drivers/infiniband/hw/qedr/qedr.h:629:9-10: WARNING: return of 0/1 in
> function 'qedr_qp_has_rq' with return type bool.
>
> ./drivers/infiniband/hw/qedr/qedr.h:620:9-10: WARNING: return of 0/1 in
> function 'qedr_qp_has_sq' with return type bool.
>
> Reported-by: Abaci Robot<[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/infiniband/hw/qedr/qedr.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qedr/qedr.h
> b/drivers/infiniband/hw/qedr/qedr.h
> index 9dde703..3cb4feb 100644
> --- a/drivers/infiniband/hw/qedr/qedr.h
> +++ b/drivers/infiniband/hw/qedr/qedr.h
> @@ -617,18 +617,18 @@ static inline bool qedr_qp_has_srq(struct qedr_qp
> *qp) static inline bool qedr_qp_has_sq(struct qedr_qp *qp) {
> if (qp->qp_type == IB_QPT_GSI || qp->qp_type ==
> IB_QPT_XRC_TGT)
> - return 0;
> + return false;
>
> - return 1;
> + return true;
> }
>
> static inline bool qedr_qp_has_rq(struct qedr_qp *qp) {
> if (qp->qp_type == IB_QPT_GSI || qp->qp_type == IB_QPT_XRC_INI
> ||
> qp->qp_type == IB_QPT_XRC_TGT || qedr_qp_has_srq(qp))
> - return 0;
> + return false;
>
> - return 1;
> + return true;
> }
>
> static inline struct qedr_user_mmap_entry *
> --
> 1.8.3.1

Thanks,?

Acked-by: Michal Kalderon?<[email protected]>

2021-02-10 18:35:12

by Jason Gunthorpe

Subject: Re: [PATCH] DMA/qedr: Use true and false for bool variable

On Wed, Feb 10, 2021 at 05:38:21PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warning:
>
> ./drivers/infiniband/hw/qedr/qedr.h:629:9-10: WARNING: return of 0/1 in
> function 'qedr_qp_has_rq' with return type bool.
>
> ./drivers/infiniband/hw/qedr/qedr.h:620:9-10: WARNING: return of 0/1 in
> function 'qedr_qp_has_sq' with return type bool.
>
> Reported-by: Abaci Robot<[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> Acked-by: Michal Kalderon <[email protected]>
> ---
> drivers/infiniband/hw/qedr/qedr.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Applied to for-next, thanks

Jason