2021-02-09 08:56:25

by Jiapeng Chong

Subject: [PATCH bpf-next] selftests/bpf: Simplify the calculation of variables

Fix the following coccicheck warnings:

./tools/testing/selftests/bpf/xdpxceiver.c:954:28-30: WARNING !A || A &&
B is equivalent to !A || B.

./tools/testing/selftests/bpf/xdpxceiver.c:932:28-30: WARNING !A || A &&
B is equivalent to !A || B.

./tools/testing/selftests/bpf/xdpxceiver.c:909:28-30: WARNING !A || A &&
B is equivalent to !A || B.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
tools/testing/selftests/bpf/xdpxceiver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/testing/selftests/bpf/xdpxceiver.c
index 99ea6cf..f4a96d5 100644
--- a/tools/testing/selftests/bpf/xdpxceiver.c
+++ b/tools/testing/selftests/bpf/xdpxceiver.c
@@ -897,7 +897,7 @@ static void *worker_testapp_validate(void *arg)
ksft_print_msg("Destroying socket\n");
}

- if (!opt_bidi || (opt_bidi && bidi_pass)) {
+ if (!opt_bidi || bidi_pass) {
xsk_socket__delete(ifobject->xsk->xsk);
(void)xsk_umem__delete(ifobject->umem->umem);
}
@@ -922,7 +922,7 @@ static void testapp_validate(void)
pthread_mutex_lock(&sync_mutex);

/*Spawn RX thread */
- if (!opt_bidi || (opt_bidi && !bidi_pass)) {
+ if (!opt_bidi || !bidi_pass) {
if (pthread_create(&t0, &attr, worker_testapp_validate, ifdict[1]))
exit_with_error(errno);
} else if (opt_bidi && bidi_pass) {
@@ -942,7 +942,7 @@ static void testapp_validate(void)
pthread_mutex_unlock(&sync_mutex);

/*Spawn TX thread */
- if (!opt_bidi || (opt_bidi && !bidi_pass)) {
+ if (!opt_bidi || !bidi_pass) {
if (pthread_create(&t1, &attr, worker_testapp_validate, ifdict[0]))
exit_with_error(errno);
} else if (opt_bidi && bidi_pass) {
--
1.8.3.1

2021-02-10 20:26:17

by patchwork-bot+netdevbpf

Subject: Re: [PATCH bpf-next] selftests/bpf: Simplify the calculation of variables

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Tue, 9 Feb 2021 16:46:38 +0800 you wrote:
> Fix the following coccicheck warnings:
>
> ./tools/testing/selftests/bpf/xdpxceiver.c:954:28-30: WARNING !A || A &&
> B is equivalent to !A || B.
>
> ./tools/testing/selftests/bpf/xdpxceiver.c:932:28-30: WARNING !A || A &&
> B is equivalent to !A || B.
>
> [...]

Here is the summary with links:
- [bpf-next] selftests/bpf: Simplify the calculation of variables
https://git.kernel.org/bpf/bpf-next/c/bd2d4e6c6e9f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html