2021-02-18 08:10:14

by Zou Wei

Subject: [PATCH -next] soc / drm: mediatek: Mark mtk_mutex_driver with static keyword

Fix the following sparse warning:

drivers/soc/mediatek/mtk-mutex.c:464:24: warning: symbol 'mtk_mutex_driver' was not declared. Should it be static?

Signed-off-by: Zou Wei <[email protected]>
---
drivers/soc/mediatek/mtk-mutex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
index f531b11..3a315a6 100644
--- a/drivers/soc/mediatek/mtk-mutex.c
+++ b/drivers/soc/mediatek/mtk-mutex.c
@@ -461,7 +461,7 @@ static const struct of_device_id mutex_driver_dt_match[] = {
};
MODULE_DEVICE_TABLE(of, mutex_driver_dt_match);

-struct platform_driver mtk_mutex_driver = {
+static struct platform_driver mtk_mutex_driver = {
.probe = mtk_mutex_probe,
.remove = mtk_mutex_remove,
.driver = {
--
2.6.2

2021-02-18 23:18:59

by Chun-Kuang Hu

Subject: Re: [PATCH -next] soc / drm: mediatek: Mark mtk_mutex_driver with static keyword

Hi, Zou:

Zou Wei <[email protected]> 於 2021年2月18日 週四 下午3:12寫道：
>
> Fix the following sparse warning:
>
> drivers/soc/mediatek/mtk-mutex.c:464:24: warning: symbol 'mtk_mutex_driver' was not declared. Should it be static?
>

Reviewed-by: Chun-Kuang Hu <[email protected]>

> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/soc/mediatek/mtk-mutex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
> index f531b11..3a315a6 100644
> --- a/drivers/soc/mediatek/mtk-mutex.c
> +++ b/drivers/soc/mediatek/mtk-mutex.c
> @@ -461,7 +461,7 @@ static const struct of_device_id mutex_driver_dt_match[] = {
> };
> MODULE_DEVICE_TABLE(of, mutex_driver_dt_match);
>
> -struct platform_driver mtk_mutex_driver = {
> +static struct platform_driver mtk_mutex_driver = {
> .probe = mtk_mutex_probe,
> .remove = mtk_mutex_remove,
> .driver = {
> --
> 2.6.2
>
>
> _______________________________________________
> Linux-mediatek mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-mediatek