2021-02-23 09:28:18

by Jiapeng Chong

Subject: [PATCH] drm/ttm/ttm_bo: make ttm_bo_glob_use_count static

Fix the following sparse warning:

drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol
'ttm_bo_glob_use_count' was not declared. Should it be static?

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index b65f4b1..107dd13 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -50,7 +50,7 @@
* ttm_global_mutex - protecting the global BO state
*/
DEFINE_MUTEX(ttm_global_mutex);
-unsigned ttm_bo_glob_use_count;
+static unsigned ttm_bo_glob_use_count;
struct ttm_bo_global ttm_bo_glob;
EXPORT_SYMBOL(ttm_bo_glob);

--
1.8.3.1

2021-02-23 09:35:43

by Christian König

Subject: Re: [PATCH] drm/ttm/ttm_bo: make ttm_bo_glob_use_count static

Am 23.02.21 um 09:54 schrieb Jiapeng Chong:
> Fix the following sparse warning:
>
> drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol
> 'ttm_bo_glob_use_count' was not declared. Should it be static?

IIRC we already have a patch for this on the mailing list and the mutex
can be static as well.

Christian.

>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index b65f4b1..107dd13 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -50,7 +50,7 @@
> * ttm_global_mutex - protecting the global BO state
> */
> DEFINE_MUTEX(ttm_global_mutex);
> -unsigned ttm_bo_glob_use_count;
> +static unsigned ttm_bo_glob_use_count;
> struct ttm_bo_global ttm_bo_glob;
> EXPORT_SYMBOL(ttm_bo_glob);
>