2021-03-02 21:32:55

by Yang Li

Subject: [PATCH] of: property: Remove unneeded return variable

This patch removes unneeded return variables, using only
'0' instead.
It fixes the following warning detected by coccinelle:
./drivers/of/property.c:1371:5-8: Unneeded variable: "ret". Return "0"
on line 1388

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/of/property.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/of/property.c b/drivers/of/property.c
index 5036a36..2381695 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1368,7 +1368,6 @@ static int of_link_property(struct device_node *con_np, const char *prop_name)
const struct supplier_bindings *s = of_supplier_bindings;
unsigned int i = 0;
bool matched = false;
- int ret = 0;

/* Do not stop at first failed link, link all available suppliers. */
while (!matched && s->parse_prop) {
@@ -1385,7 +1384,7 @@ static int of_link_property(struct device_node *con_np, const char *prop_name)
}
s++;
}
- return ret;
+ return 0;
}

static int of_fwnode_add_links(struct fwnode_handle *fwnode)
--
1.8.3.1

2021-03-08 18:46:09

by Rob Herring (Arm)

Subject: Re: [PATCH] of: property: Remove unneeded return variable

On Tue, 02 Mar 2021 17:16:38 +0800, Yang Li wrote:
> This patch removes unneeded return variables, using only
> '0' instead.
> It fixes the following warning detected by coccinelle:
> ./drivers/of/property.c:1371:5-8: Unneeded variable: "ret". Return "0"
> on line 1388
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/of/property.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Applied, thanks!