2021-03-08 08:46:04

by Yang Li

Subject: [PATCH v2] usb: typec: tcpm: turn tcpm_ams_finish into void function

This function always return '0' and no callers use the return value.
So make it a void function.

This eliminates the following coccicheck warning:
./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret".
Return "0" on line 794

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---

Change in v2:
-remove the unnecessary return statement

drivers/usb/typec/tcpm/tcpm.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index be0b646..8159229 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -773,10 +773,8 @@ static enum typec_cc_status tcpm_rp_cc(struct tcpm_port *port)
return TYPEC_CC_RP_DEF;
}

-static int tcpm_ams_finish(struct tcpm_port *port)
+static void tcpm_ams_finish(struct tcpm_port *port)
{
- int ret = 0;
-
tcpm_log(port, "AMS %s finished", tcpm_ams_str[port->ams]);

if (port->pd_capable && port->pwr_role == TYPEC_SOURCE) {
@@ -790,8 +788,6 @@ static int tcpm_ams_finish(struct tcpm_port *port)

port->in_ams = false;
port->ams = NONE_AMS;
-
- return ret;
}

static int tcpm_pd_transmit(struct tcpm_port *port,
--
1.8.3.1

2021-03-08 11:05:38

by Heikki Krogerus

Subject: Re: [PATCH v2] usb: typec: tcpm: turn tcpm_ams_finish into void function

On Mon, Mar 08, 2021 at 02:35:30PM +0800, Yang Li wrote:
> This function always return '0' and no callers use the return value.
> So make it a void function.
>
> This eliminates the following coccicheck warning:
> ./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret".
> Return "0" on line 794
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
>
> Change in v2:
> -remove the unnecessary return statement
>
> drivers/usb/typec/tcpm/tcpm.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index be0b646..8159229 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -773,10 +773,8 @@ static enum typec_cc_status tcpm_rp_cc(struct tcpm_port *port)
> return TYPEC_CC_RP_DEF;
> }
>
> -static int tcpm_ams_finish(struct tcpm_port *port)
> +static void tcpm_ams_finish(struct tcpm_port *port)
> {
> - int ret = 0;
> -
> tcpm_log(port, "AMS %s finished", tcpm_ams_str[port->ams]);
>
> if (port->pd_capable && port->pwr_role == TYPEC_SOURCE) {
> @@ -790,8 +788,6 @@ static int tcpm_ams_finish(struct tcpm_port *port)
>
> port->in_ams = false;
> port->ams = NONE_AMS;
> -
> - return ret;
> }
>
> static int tcpm_pd_transmit(struct tcpm_port *port,
> --
> 1.8.3.1

--
heikki

2021-03-08 18:32:16

by Guenter Roeck

Subject: Re: [PATCH v2] usb: typec: tcpm: turn tcpm_ams_finish into void function

On Mon, Mar 08, 2021 at 02:35:30PM +0800, Yang Li wrote:
> This function always return '0' and no callers use the return value.
> So make it a void function.
>
> This eliminates the following coccicheck warning:
> ./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret".
> Return "0" on line 794
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
>
> Change in v2:
> -remove the unnecessary return statement
>
> drivers/usb/typec/tcpm/tcpm.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index be0b646..8159229 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -773,10 +773,8 @@ static enum typec_cc_status tcpm_rp_cc(struct tcpm_port *port)
> return TYPEC_CC_RP_DEF;
> }
>
> -static int tcpm_ams_finish(struct tcpm_port *port)
> +static void tcpm_ams_finish(struct tcpm_port *port)
> {
> - int ret = 0;
> -
> tcpm_log(port, "AMS %s finished", tcpm_ams_str[port->ams]);
>
> if (port->pd_capable && port->pwr_role == TYPEC_SOURCE) {
> @@ -790,8 +788,6 @@ static int tcpm_ams_finish(struct tcpm_port *port)
>
> port->in_ams = false;
> port->ams = NONE_AMS;
> -
> - return ret;
> }
>
> static int tcpm_pd_transmit(struct tcpm_port *port,
> --
> 1.8.3.1
>