2021-03-09 09:39:52

by Jiapeng Chong

Subject: [PATCH] scsi: csiostor: Assign boolean values to a bool variable

Fix the following coccicheck warnings:

./drivers/scsi/csiostor/csio_scsi.c:150:9-10: WARNING: return of 0/1 in
function 'csio_scsi_itnexus_loss_error' with return type bool.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/scsi/csiostor/csio_scsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c
index 55e74da..56b9ad0 100644
--- a/drivers/scsi/csiostor/csio_scsi.c
+++ b/drivers/scsi/csiostor/csio_scsi.c
@@ -147,9 +147,9 @@ static int csio_do_abrt_cls(struct csio_hw *,
case FW_ERR_RDEV_LOST:
case FW_ERR_RDEV_LOGO:
case FW_ERR_RDEV_IMPL_LOGO:
- return 1;
+ return true;
}
- return 0;
+ return false;
}

/*
--
1.8.3.1

2021-03-19 03:48:42

by Martin K. Petersen

Subject: Re: [PATCH] scsi: csiostor: Assign boolean values to a bool variable

On Tue, 9 Mar 2021 17:37:48 +0800, Jiapeng Chong wrote:

> Fix the following coccicheck warnings:
>
> ./drivers/scsi/csiostor/csio_scsi.c:150:9-10: WARNING: return of 0/1 in
> function 'csio_scsi_itnexus_loss_error' with return type bool.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: csiostor: Assign boolean values to a bool variable
https://git.kernel.org/mkp/scsi/c/2ed0fc2b9a79

--
Martin K. Petersen Oracle Linux Engineering