2021-03-10 08:54:56

by Yang Li

Subject: [PATCH] isdn: mISDN: remove unneeded variable 'ret'

Fix the following coccicheck warning:
./drivers/isdn/mISDN/dsp_core.c:956:6-9: Unneeded variable: "err".
Return "0" on line 1001

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/isdn/mISDN/dsp_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/isdn/mISDN/dsp_core.c b/drivers/isdn/mISDN/dsp_core.c
index 038e72a..4946ea1 100644
--- a/drivers/isdn/mISDN/dsp_core.c
+++ b/drivers/isdn/mISDN/dsp_core.c
@@ -953,7 +953,6 @@
{
struct dsp *dsp = container_of(ch, struct dsp, ch);
u_long flags;
- int err = 0;

if (debug & DEBUG_DSP_CTRL)
printk(KERN_DEBUG "%s:(%x)\n", __func__, cmd);
@@ -998,7 +997,7 @@
module_put(THIS_MODULE);
break;
}
- return err;
+ return 0;
}

static void
--
1.8.3.1

2021-03-10 21:02:03

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] isdn: mISDN: remove unneeded variable 'ret'

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 10 Mar 2021 16:53:04 +0800 you wrote:
> Fix the following coccicheck warning:
> ./drivers/isdn/mISDN/dsp_core.c:956:6-9: Unneeded variable: "err".
> Return "0" on line 1001
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
>
> [...]

Here is the summary with links:
- isdn: mISDN: remove unneeded variable 'ret'
https://git.kernel.org/netdev/net-next/c/762c1adb1c15

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html