2021-03-11 07:32:46

by Satya Priya

[permalink] [raw]
Subject: [PATCH 0/3] Add RTC support for PMIC PMK8350

Convert pm8xxx bindings to yaml and add pmk8350 rtc binding.

satya priya (3):
rtc: pm8xxx: Add RTC support for PMIC PMK8350
dt-bindings: mfd: Convert pm8xxx bindings to yaml
dt-bindings: mfd: Add compatible for pmk8350 rtc

.../devicetree/bindings/mfd/qcom-pm8xxx.txt | 99 -------------------
.../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 109 +++++++++++++++++++++
drivers/rtc/rtc-pm8xxx.c | 11 +++
3 files changed, 120 insertions(+), 99 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt
create mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


2021-03-11 07:35:41

by Satya Priya

[permalink] [raw]
Subject: [PATCH 1/3] rtc: pm8xxx: Add RTC support for PMIC PMK8350

Add the comaptible string for PMIC PMK8350.

Signed-off-by: satya priya <[email protected]>
---
drivers/rtc/rtc-pm8xxx.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
index eb20659..29a1c65 100644
--- a/drivers/rtc/rtc-pm8xxx.c
+++ b/drivers/rtc/rtc-pm8xxx.c
@@ -445,6 +445,16 @@ static const struct pm8xxx_rtc_regs pm8941_regs = {
.alarm_en = BIT(7),
};

+static const struct pm8xxx_rtc_regs pmk8350_regs = {
+ .ctrl = 0x6146,
+ .write = 0x6140,
+ .read = 0x6148,
+ .alarm_rw = 0x6240,
+ .alarm_ctrl = 0x6246,
+ .alarm_ctrl2 = 0x6248,
+ .alarm_en = BIT(7),
+};
+
/*
* Hardcoded RTC bases until IORESOURCE_REG mapping is figured out
*/
@@ -453,6 +463,7 @@ static const struct of_device_id pm8xxx_id_table[] = {
{ .compatible = "qcom,pm8018-rtc", .data = &pm8921_regs },
{ .compatible = "qcom,pm8058-rtc", .data = &pm8058_regs },
{ .compatible = "qcom,pm8941-rtc", .data = &pm8941_regs },
+ { .compatible = "qcom,pmk8350-rtc", .data = &pmk8350_regs },
{ },
};
MODULE_DEVICE_TABLE(of, pm8xxx_id_table);
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-03-11 17:02:04

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 1/3] rtc: pm8xxx: Add RTC support for PMIC PMK8350

On Thu 11 Mar 01:29 CST 2021, satya priya wrote:

> Add the comaptible string for PMIC PMK8350.
>

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> Signed-off-by: satya priya <[email protected]>
> ---
> drivers/rtc/rtc-pm8xxx.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
> index eb20659..29a1c65 100644
> --- a/drivers/rtc/rtc-pm8xxx.c
> +++ b/drivers/rtc/rtc-pm8xxx.c
> @@ -445,6 +445,16 @@ static const struct pm8xxx_rtc_regs pm8941_regs = {
> .alarm_en = BIT(7),
> };
>
> +static const struct pm8xxx_rtc_regs pmk8350_regs = {
> + .ctrl = 0x6146,
> + .write = 0x6140,
> + .read = 0x6148,
> + .alarm_rw = 0x6240,
> + .alarm_ctrl = 0x6246,
> + .alarm_ctrl2 = 0x6248,
> + .alarm_en = BIT(7),
> +};
> +
> /*
> * Hardcoded RTC bases until IORESOURCE_REG mapping is figured out
> */
> @@ -453,6 +463,7 @@ static const struct of_device_id pm8xxx_id_table[] = {
> { .compatible = "qcom,pm8018-rtc", .data = &pm8921_regs },
> { .compatible = "qcom,pm8058-rtc", .data = &pm8058_regs },
> { .compatible = "qcom,pm8941-rtc", .data = &pm8941_regs },
> + { .compatible = "qcom,pmk8350-rtc", .data = &pmk8350_regs },
> { },
> };
> MODULE_DEVICE_TABLE(of, pm8xxx_id_table);
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>