2021-03-18 06:23:43

by Chunfeng Yun

[permalink] [raw]
Subject: [PATCH] arm64: dts: mt8173: fix wrong power-domain phandle of pmic

Due to power domain controller is added, the power domain's
phanle is also changed from 'scpsys' to 'spm', but forget to
modify pmic node's

Fixes: 8b6562644df9 ("arm64: dts: mediatek: Add mt8173 power domain controller")
Signed-off-by: Chunfeng Yun <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
index 6dffada2e66b..28aa634c9780 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
@@ -294,7 +294,7 @@

&pwrap {
/* Only MT8173 E1 needs USB power domain */
- power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>;
+ power-domains = <&spm MT8173_POWER_DOMAIN_USB>;

pmic: mt6397 {
compatible = "mediatek,mt6397";
--
2.18.0


2021-03-18 09:25:47

by Enric Balletbo i Serra

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: mt8173: fix wrong power-domain phandle of pmic

Hi Chunfeng Yun,

Thank you for the patch.

On 18/3/21 7:18, Chunfeng Yun wrote:
> Due to power domain controller is added, the power domain's
> phanle is also changed from 'scpsys' to 'spm', but forget to
> modify pmic node's
>
> Fixes: 8b6562644df9 ("arm64: dts: mediatek: Add mt8173 power domain controller")
> Signed-off-by: Chunfeng Yun <[email protected]>

Reviewed-by: Enric Balletbo i Serra <[email protected]>

> ---
> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> index 6dffada2e66b..28aa634c9780 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> @@ -294,7 +294,7 @@
>
> &pwrap {
> /* Only MT8173 E1 needs USB power domain */
> - power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>;
> + power-domains = <&spm MT8173_POWER_DOMAIN_USB>;
>
> pmic: mt6397 {
> compatible = "mediatek,mt6397";
>

2021-03-29 17:24:26

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: mt8173: fix wrong power-domain phandle of pmic



On 18/03/2021 07:18, Chunfeng Yun wrote:
> Due to power domain controller is added, the power domain's
> phanle is also changed from 'scpsys' to 'spm', but forget to
> modify pmic node's
>
> Fixes: 8b6562644df9 ("arm64: dts: mediatek: Add mt8173 power domain controller")
> Signed-off-by: Chunfeng Yun <[email protected]>

Applied to v5.12-next/dts64
Thanks!

> ---
> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> index 6dffada2e66b..28aa634c9780 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> @@ -294,7 +294,7 @@
>
> &pwrap {
> /* Only MT8173 E1 needs USB power domain */
> - power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>;
> + power-domains = <&spm MT8173_POWER_DOMAIN_USB>;
>
> pmic: mt6397 {
> compatible = "mediatek,mt6397";
>