2021-03-09 10:02:35

by Jiapeng Chong

Subject: [PATCH] x86/kaslr: Assign boolean values to a bool variable

Fix the following coccicheck warnings:

./arch/x86/boot/compressed/kaslr.c:642:10-11: WARNING: return of 0/1 in
function 'process_mem_region' with return type bool.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
arch/x86/boot/compressed/kaslr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
index b92fffb..e366907 100644
--- a/arch/x86/boot/compressed/kaslr.c
+++ b/arch/x86/boot/compressed/kaslr.c
@@ -639,9 +639,9 @@ static bool process_mem_region(struct mem_vector *region,

if (slot_area_index == MAX_SLOT_AREA) {
debug_putstr("Aborted e820/efi memmap scan (slot_areas full)!\n");
- return 1;
+ return true;
}
- return 0;
+ return false;
}

#if defined(CONFIG_MEMORY_HOTREMOVE) && defined(CONFIG_ACPI)
--
1.8.3.1

2021-03-19 12:33:00

by tip-bot2 for Alexey Makhalov

Subject: [tip: x86/cleanups] x86/kaslr: Return boolean values from a function returning bool

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID: 21d6a7dcbfba5e7b31f4e9d555a9be362578bfc3
Gitweb: https://git.kernel.org/tip/21d6a7dcbfba5e7b31f4e9d555a9be362578bfc3
Author: Jiapeng Chong <[email protected]>
AuthorDate: Tue, 09 Mar 2021 17:59:23 +08:00
Committer: Borislav Petkov <[email protected]>
CommitterDate: Fri, 19 Mar 2021 13:25:07 +01:00

x86/kaslr: Return boolean values from a function returning bool

Fix the following coccicheck warnings:

./arch/x86/boot/compressed/kaslr.c:642:10-11: WARNING: return of 0/1 in
function 'process_mem_region' with return type bool.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
Link: https://lkml.kernel.org/r/1615283963-67277-1-git-send-email-jiapeng.chong@linux.alibaba.com
---
arch/x86/boot/compressed/kaslr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
index b92fffb..e366907 100644
--- a/arch/x86/boot/compressed/kaslr.c
+++ b/arch/x86/boot/compressed/kaslr.c
@@ -639,9 +639,9 @@ static bool process_mem_region(struct mem_vector *region,

if (slot_area_index == MAX_SLOT_AREA) {
debug_putstr("Aborted e820/efi memmap scan (slot_areas full)!\n");
- return 1;
+ return true;
}
- return 0;
+ return false;
}

#if defined(CONFIG_MEMORY_HOTREMOVE) && defined(CONFIG_ACPI)