2021-03-29 01:42:12

by Huang Guobin

Subject: [PATCH net-next v2] net: mdio: Remove redundant dev_err call in mdio_mux_iproc_probe()

From: Guobin Huang <[email protected]>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Guobin Huang <[email protected]>
---
drivers/net/mdio/mdio-mux-bcm-iproc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/mdio/mdio-mux-bcm-iproc.c b/drivers/net/mdio/mdio-mux-bcm-iproc.c
index 641cfa41f492..03261e6b9ceb 100644
--- a/drivers/net/mdio/mdio-mux-bcm-iproc.c
+++ b/drivers/net/mdio/mdio-mux-bcm-iproc.c
@@ -197,10 +197,8 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
res->end = res->start + MDIO_REG_ADDR_SPACE_SIZE - 1;
}
md->base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(md->base)) {
- dev_err(&pdev->dev, "failed to ioremap register\n");
+ if (IS_ERR(md->base))
return PTR_ERR(md->base);
- }

md->mii_bus = devm_mdiobus_alloc(&pdev->dev);
if (!md->mii_bus) {

2021-03-29 20:24:04

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next v2] net: mdio: Remove redundant dev_err call in mdio_mux_iproc_probe()

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 29 Mar 2021 09:38:32 +0800 you wrote:
> From: Guobin Huang <[email protected]>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Guobin Huang <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next,v2] net: mdio: Remove redundant dev_err call in mdio_mux_iproc_probe()
https://git.kernel.org/netdev/net-next/c/6be836818872

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html