2021-03-30 09:53:30

by Jiapeng Chong

Subject: [PATCH] ppp: deflate: Remove useless call "zlib_inflateEnd"

Fix the following whitescan warning:

Calling "zlib_inflateEnd(&state->strm)" is only useful for its return
value, which is ignored.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/ppp/ppp_deflate.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ppp/ppp_deflate.c b/drivers/net/ppp/ppp_deflate.c
index c457f84..e6d48e5 100644
--- a/drivers/net/ppp/ppp_deflate.c
+++ b/drivers/net/ppp/ppp_deflate.c
@@ -279,7 +279,6 @@ static void z_decomp_free(void *arg)
struct ppp_deflate_state *state = (struct ppp_deflate_state *) arg;

if (state) {
- zlib_inflateEnd(&state->strm);
vfree(state->strm.workspace);
kfree(state);
}
--
1.8.3.1

2021-03-31 00:14:36

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] ppp: deflate: Remove useless call "zlib_inflateEnd"

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 30 Mar 2021 17:51:30 +0800 you wrote:
> Fix the following whitescan warning:
>
> Calling "zlib_inflateEnd(&state->strm)" is only useful for its return
> value, which is ignored.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
>
> [...]

Here is the summary with links:
- ppp: deflate: Remove useless call "zlib_inflateEnd"
https://git.kernel.org/netdev/net-next/c/dc5fa2073f63

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html