2021-04-01 06:58:30

by Zhangshaokun

Subject: [PATCH] fs/buffer.c: Delete redundant uptodate check for buffer

From: Yang Guo <[email protected]>

The buffer uptodate state has been checked in function set_buffer_uptodate,
there is no need use buffer_uptodate before calling set_buffer_uptodate and
delete it.

Cc: Alexander Viro <[email protected]>
Signed-off-by: Yang Guo <[email protected]>
Signed-off-by: Shaokun Zhang <[email protected]>
---
fs/buffer.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/buffer.c b/fs/buffer.c
index 673cfbef9eec..2c0d0b3f3203 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -2055,8 +2055,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
block_end = block_start + blocksize;
if (block_end <= from || block_start >= to) {
if (PageUptodate(page)) {
- if (!buffer_uptodate(bh))
- set_buffer_uptodate(bh);
+ set_buffer_uptodate(bh);
}
continue;
}
@@ -2088,8 +2087,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
}
}
if (PageUptodate(page)) {
- if (!buffer_uptodate(bh))
- set_buffer_uptodate(bh);
+ set_buffer_uptodate(bh);
continue;
}
if (!buffer_uptodate(bh) && !buffer_delay(bh) &&
--
2.7.4

2021-04-12 02:01:05

by Zhangshaokun

Subject: Re: [PATCH] fs/buffer.c: Delete redundant uptodate check for buffer

+Cc: Andrew Morton

On 2021/4/1 14:57, Shaokun Zhang wrote:
> From: Yang Guo <[email protected]>
>
> The buffer uptodate state has been checked in function set_buffer_uptodate,
> there is no need use buffer_uptodate before calling set_buffer_uptodate and
> delete it.
>
> Cc: Alexander Viro <[email protected]>
> Signed-off-by: Yang Guo <[email protected]>
> Signed-off-by: Shaokun Zhang <[email protected]>
> ---
> fs/buffer.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 673cfbef9eec..2c0d0b3f3203 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -2055,8 +2055,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
> block_end = block_start + blocksize;
> if (block_end <= from || block_start >= to) {
> if (PageUptodate(page)) {
> - if (!buffer_uptodate(bh))
> - set_buffer_uptodate(bh);
> + set_buffer_uptodate(bh);
> }
> continue;
> }
> @@ -2088,8 +2087,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
> }
> }
> if (PageUptodate(page)) {
> - if (!buffer_uptodate(bh))
> - set_buffer_uptodate(bh);
> + set_buffer_uptodate(bh);
> continue;
> }
> if (!buffer_uptodate(bh) && !buffer_delay(bh) &&
>

2021-05-07 07:11:54

by Zhangshaokun

Subject: Re: [PATCH] fs/buffer.c: Delete redundant uptodate check for buffer

Hi Andrew,

A gentle ping.

Thanks,
Shaokun

On 2021/4/12 9:54, Shaokun Zhang wrote:
> +Cc: Andrew Morton
>
> On 2021/4/1 14:57, Shaokun Zhang wrote:
>> From: Yang Guo <[email protected]>
>>
>> The buffer uptodate state has been checked in function set_buffer_uptodate,
>> there is no need use buffer_uptodate before calling set_buffer_uptodate and
>> delete it.
>>
>> Cc: Alexander Viro <[email protected]>
>> Signed-off-by: Yang Guo <[email protected]>
>> Signed-off-by: Shaokun Zhang <[email protected]>
>> ---
>> fs/buffer.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/fs/buffer.c b/fs/buffer.c
>> index 673cfbef9eec..2c0d0b3f3203 100644
>> --- a/fs/buffer.c
>> +++ b/fs/buffer.c
>> @@ -2055,8 +2055,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
>> block_end = block_start + blocksize;
>> if (block_end <= from || block_start >= to) {
>> if (PageUptodate(page)) {
>> - if (!buffer_uptodate(bh))
>> - set_buffer_uptodate(bh);
>> + set_buffer_uptodate(bh);
>> }
>> continue;
>> }
>> @@ -2088,8 +2087,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
>> }
>> }
>> if (PageUptodate(page)) {
>> - if (!buffer_uptodate(bh))
>> - set_buffer_uptodate(bh);
>> + set_buffer_uptodate(bh);
>> continue;
>> }
>> if (!buffer_uptodate(bh) && !buffer_delay(bh) &&
>>