2021-04-01 18:34:29

by liuqi (BA)

Subject: [PATCH] iommu: Remove duplicate check of pasids

Remove duplicate check of pasids in amd_iommu_domain_enable_v2(), as it
has been guaranteed in amd_iommu_init_device().

Signed-off-by: Qi Liu <[email protected]>
---
drivers/iommu/amd/iommu.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index 107316e..7ca9f2f 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -2310,9 +2310,6 @@ int amd_iommu_domain_enable_v2(struct iommu_domain *dom, int pasids)
unsigned long flags;
int levels, ret;

- if (pasids <= 0 || pasids > (PASID_MASK + 1))
- return -EINVAL;
-
/* Number of GCR3 table levels required */
for (levels = 0; (pasids - 1) & ~0x1ff; pasids >>= 9)
levels += 1;
--
2.8.1

2021-04-07 20:40:11

by Joerg Roedel

Subject: Re: [PATCH] iommu: Remove duplicate check of pasids

On Thu, Apr 01, 2021 at 07:19:16PM +0800, Qi Liu wrote:
> Remove duplicate check of pasids in amd_iommu_domain_enable_v2(), as it
> has been guaranteed in amd_iommu_init_device().
>
> Signed-off-by: Qi Liu <[email protected]>
> ---
> drivers/iommu/amd/iommu.c | 3 ---
> 1 file changed, 3 deletions(-)

Applied, thanks.