2021-04-06 20:50:37

by Clark Wang

[permalink] [raw]
Subject: [PATCH V2 11/18] dt-bindings: i2c: imx-lpi2c: Add bus recovery example

Add i2c bus recovery configuration example.

Signed-off-by: Clark Wang <[email protected]>
---
V2 changes:
- New patch added in V2
---
.../devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
index 29b9447f3b84..0a4b28827dcc 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
@@ -42,6 +42,15 @@ properties:
power-domains:
maxItems: 1

+ pinctrl-names:
+ minItems: 1
+
+ scl-gpios:
+ maxItems: 1
+
+ sda-gpios:
+ maxItems: 1
+
required:
- compatible
- reg
@@ -61,4 +70,9 @@ examples:
interrupt-parent = <&intc>;
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX7ULP_CLK_LPI2C7>;
+ pinctrl-names = "default","gpio";
+ pinctrl-0 = <&pinctrl_i2c>;
+ pinctrl-1 = <&pinctrl_i2c_recovery>;
+ scl-gpios = <&gpio5 14 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+ sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
};
--
2.25.1


2021-04-06 22:12:55

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH V2 11/18] dt-bindings: i2c: imx-lpi2c: Add bus recovery example

On Tue, 06 Apr 2021 19:32:59 +0800, Clark Wang wrote:
> Add i2c bus recovery configuration example.
>
> Signed-off-by: Clark Wang <[email protected]>
> ---
> V2 changes:
> - New patch added in V2
> ---
> .../devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.example.dts:31.37-38 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:377: Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1414: dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1462762

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

2021-05-21 10:03:27

by Aisheng Dong

[permalink] [raw]
Subject: RE: [PATCH V2 11/18] dt-bindings: i2c: imx-lpi2c: Add bus recovery example

> From: Clark Wang <[email protected]>
> Sent: Tuesday, April 6, 2021 7:33 PM
> Subject: [PATCH V2 11/18] dt-bindings: i2c: imx-lpi2c: Add bus recovery
> example

s/example/support

and pls pass make dt_binding_check

>
> Add i2c bus recovery configuration example.
>
> Signed-off-by: Clark Wang <[email protected]>
> ---
> V2 changes:
> - New patch added in V2
> ---
> .../devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> index 29b9447f3b84..0a4b28827dcc 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> @@ -42,6 +42,15 @@ properties:
> power-domains:
> maxItems: 1
>
> + pinctrl-names:
> + minItems: 1
> +
> + scl-gpios:
> + maxItems: 1
> +
> + sda-gpios:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> @@ -61,4 +70,9 @@ examples:
> interrupt-parent = <&intc>;
> interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX7ULP_CLK_LPI2C7>;
> + pinctrl-names = "default","gpio";
> + pinctrl-0 = <&pinctrl_i2c>;
> + pinctrl-1 = <&pinctrl_i2c_recovery>;
> + scl-gpios = <&gpio5 14 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH |
> GPIO_OPEN_DRAIN)>;
> };
> --
> 2.25.1