2021-04-01 06:40:39

by Jiabing Wan

Subject: [PATCH] scsi: bfa: Remove unnecessary struct declaration

struct bfa_fcs_s is declared twice. One is declared
at 50th line. Remove the duplicate.
struct bfa_fcs_fabric_s is defined at 175th line.
Remove unnecessary declaration.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/scsi/bfa/bfa_fcs.h | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/bfa/bfa_fcs.h b/drivers/scsi/bfa/bfa_fcs.h
index 3e117fed95c9..c1baf5cd0d3e 100644
--- a/drivers/scsi/bfa/bfa_fcs.h
+++ b/drivers/scsi/bfa/bfa_fcs.h
@@ -217,9 +217,6 @@ struct bfa_vf_event_s {
u32 undefined;
};

-struct bfa_fcs_s;
-struct bfa_fcs_fabric_s;
-
/*
* @todo : need to move to a global config file.
* Maximum Rports supported per port (physical/logical).
--
2.25.1

2021-04-13 13:38:58

by Martin K. Petersen

Subject: Re: [PATCH] scsi: bfa: Remove unnecessary struct declaration

On Thu, 1 Apr 2021 14:35:34 +0800, Wan Jiabing wrote:

> struct bfa_fcs_s is declared twice. One is declared
> at 50th line. Remove the duplicate.
> struct bfa_fcs_fabric_s is defined at 175th line.
> Remove unnecessary declaration.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: bfa: Remove unnecessary struct declaration
https://git.kernel.org/mkp/scsi/c/c3b0d087763f

--
Martin K. Petersen Oracle Linux Engineering