2021-04-13 14:17:58

by Yang Li

[permalink] [raw]
Subject: [PATCH] i2c: busses: remove unused including <linux/version.h>

Fix the following versioncheck warnings:
./drivers/i2c/busses/i2c-xgene-slimpro.c: 22 linux/version.h not needed.
./drivers/i2c/busses/i2c-brcmstb.c: 25 linux/version.h not needed.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/i2c/busses/i2c-brcmstb.c | 1 -
drivers/i2c/busses/i2c-xgene-slimpro.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcmstb.c
index ba766d2..490ee39 100644
--- a/drivers/i2c/busses/i2c-brcmstb.c
+++ b/drivers/i2c/busses/i2c-brcmstb.c
@@ -22,7 +22,6 @@
#include <linux/platform_device.h>
#include <linux/sched.h>
#include <linux/slab.h>
-#include <linux/version.h>

#define N_DATA_REGS 8

diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index 63cbb9c7..bba08cb 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -19,7 +19,6 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/platform_device.h>
-#include <linux/version.h>

#define MAILBOX_OP_TIMEOUT 1000 /* Operation time out in ms */
#define MAILBOX_I2C_INDEX 0
--
1.8.3.1


2021-04-13 23:50:44

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: busses: remove unused including <linux/version.h>

On Tue, Apr 13, 2021 at 05:48:21PM +0800, Yang Li wrote:
> Fix the following versioncheck warnings:
> ./drivers/i2c/busses/i2c-xgene-slimpro.c: 22 linux/version.h not needed.
> ./drivers/i2c/busses/i2c-brcmstb.c: 25 linux/version.h not needed.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Thanks, but a similar patch is already in -next.

https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-next&id=660f58b6d290417828680f417f43d7b810fa9138


Attachments:
(No filename) (547.00 B)
signature.asc (849.00 B)
Download all attachments