2021-04-21 04:33:11

by Prashant Malani

Subject: [PATCH] platform/chrome: cros_ec_typec: Add DP mode check

There are certain transitional situations where the dp_mode field in the
PD_CONTROL response might not be populated with the right DP pin
assignment value yet. Add a check for that to avoid sending an invalid
value to the Type C mode switch.

Signed-off-by: Prashant Malani <[email protected]>
---
drivers/platform/chrome/cros_ec_typec.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index d3df1717a5fd..69646262fa9d 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -486,6 +486,11 @@ static int cros_typec_enable_dp(struct cros_typec_data *typec,
return -ENOTSUPP;
}

+ if (!pd_ctrl->dp_mode) {
+ dev_err(typec->dev, "No valid DP mode provided.\n");
+ return -EINVAL;
+ }
+
/* Status VDO. */
dp_data.status = DP_STATUS_ENABLED;
if (port->mux_flags & USB_PD_MUX_HPD_IRQ)
--
2.31.1.368.gbe11c130af-goog

2021-04-23 07:01:17

by Enric Balletbo i Serra

Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Add DP mode check

On Tue, 20 Apr 2021 21:21:09 -0700, Prashant Malani wrote:
> There are certain transitional situations where the dp_mode field in the
> PD_CONTROL response might not be populated with the right DP pin
> assignment value yet. Add a check for that to avoid sending an invalid
> value to the Type C mode switch.

Applied, thanks!

[1/1] platform/chrome: cros_ec_typec: Add DP mode check
commit: c5bb32f57bf3a30ed03be51f7be0840325ba8b4a

Best regards,
--
Enric Balletbo i Serra <[email protected]>