2021-04-23 20:59:32

by Souptick Joarder

Subject: [PATCH] drm/amd/display: Remove condition which is always set to True

Kernel test robot throws below warning ->

>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53:
>> warning: address of 'aconnector->mst_port->mst_mgr' will always
>> evaluate to 'true' [-Wpointer-bool-conversion]
if (!(aconnector->port &&
&aconnector->mst_port->mst_mgr))
~~
~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

Remove the condition which is always set to True.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Souptick Joarder <[email protected]>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
index 9a13f47..8f7df11 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
@@ -3012,7 +3012,7 @@ static int trigger_hpd_mst_set(void *data, u64 val)
if (!aconnector->dc_link)
continue;

- if (!(aconnector->port && &aconnector->mst_port->mst_mgr))
+ if (!aconnector->port)
continue;

link = aconnector->dc_link;
--
1.9.1

2021-04-28 21:12:59

by Alex Deucher

Subject: Re: [PATCH] drm/amd/display: Remove condition which is always set to True

On Fri, Apr 23, 2021 at 4:57 PM Souptick Joarder <[email protected]> wrote:
>
> Kernel test robot throws below warning ->
>
> >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53:
> >> warning: address of 'aconnector->mst_port->mst_mgr' will always
> >> evaluate to 'true' [-Wpointer-bool-conversion]
> if (!(aconnector->port &&
> &aconnector->mst_port->mst_mgr))
> ~~
> ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
>
> Remove the condition which is always set to True.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Souptick Joarder <[email protected]>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> index 9a13f47..8f7df11 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> @@ -3012,7 +3012,7 @@ static int trigger_hpd_mst_set(void *data, u64 val)
> if (!aconnector->dc_link)
> continue;
>
> - if (!(aconnector->port && &aconnector->mst_port->mst_mgr))
> + if (!aconnector->port)

@Harry Wentland any idea what this is supposed to be checking for?

Alex


> continue;
>
> link = aconnector->dc_link;
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel