2021-04-27 10:36:55

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] net/smc: Remove redundant assignment to rc

Variable rc is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

net/smc/af_smc.c:1079:3: warning: Value stored to 'rc' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
net/smc/af_smc.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 47340b3..be3e80b 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -1076,7 +1076,6 @@ static int smc_connect(struct socket *sock, struct sockaddr *addr,
rc = -EISCONN;
goto out;
case SMC_INIT:
- rc = 0;
break;
}

--
1.8.3.1


2021-04-27 21:24:08

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] net/smc: Remove redundant assignment to rc

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 27 Apr 2021 18:32:22 +0800 you wrote:
> Variable rc is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> net/smc/af_smc.c:1079:3: warning: Value stored to 'rc' is never read
> [clang-analyzer-deadcode.DeadStores].
>
> [...]

Here is the summary with links:
- net/smc: Remove redundant assignment to rc
https://git.kernel.org/netdev/net-next/c/6fd6c483e7ab

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html