2023-07-05 15:19:45

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/2] ARM: dts: ti: add missing space before {

Add missing whitespace between node name/label and opening {.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/ti/davinci/da850-lego-ev3.dts | 2 +-
arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi | 2 +-
arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts | 8 ++++----
3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/ti/davinci/da850-lego-ev3.dts b/arch/arm/boot/dts/ti/davinci/da850-lego-ev3.dts
index afd04a423856..17a1632a8ac1 100644
--- a/arch/arm/boot/dts/ti/davinci/da850-lego-ev3.dts
+++ b/arch/arm/boot/dts/ti/davinci/da850-lego-ev3.dts
@@ -391,7 +391,7 @@ &spi1 {
pinctrl-names = "default";
cs-gpios = <&gpio 44 GPIO_ACTIVE_LOW>;

- display@0{
+ display@0 {
compatible = "lego,ev3-lcd";
reg = <0>;
spi-max-frequency = <10000000>;
diff --git a/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi b/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
index 8949578e62e8..2062fe561642 100644
--- a/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
+++ b/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
@@ -137,7 +137,7 @@ uart01_spi2_pins: uart01-spi2-pins {
>;
};

- dfesync_rp1_pins: dfesync-rp1-pins{
+ dfesync_rp1_pins: dfesync-rp1-pins {
pinctrl-single,bits = <
/* DFESYNC_RP1_SEL */
0x0 0x0 0x2
diff --git a/arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts b/arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts
index 863552393c07..edaddc7b6a5e 100644
--- a/arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts
+++ b/arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts
@@ -58,7 +58,7 @@ vdd_core: fixed-regulator-vdd_core {
vin-supply = <&vdd_corereg>;
};

- v1_8dreg: fixed-regulator-v1_8dreg{
+ v1_8dreg: fixed-regulator-v1_8dreg {
compatible = "regulator-fixed";
regulator-name = "V1_8DREG";
regulator-min-microvolt = <1800000>;
@@ -68,7 +68,7 @@ v1_8dreg: fixed-regulator-v1_8dreg{
vin-supply = <&v24_0d>;
};

- v1_8d: fixed-regulator-v1_8d{
+ v1_8d: fixed-regulator-v1_8d {
compatible = "regulator-fixed";
regulator-name = "V1_8D";
regulator-min-microvolt = <1800000>;
@@ -78,7 +78,7 @@ v1_8d: fixed-regulator-v1_8d{
vin-supply = <&v1_8dreg>;
};

- v1_5dreg: fixed-regulator-v1_5dreg{
+ v1_5dreg: fixed-regulator-v1_5dreg {
compatible = "regulator-fixed";
regulator-name = "V1_5DREG";
regulator-min-microvolt = <1500000>;
@@ -88,7 +88,7 @@ v1_5dreg: fixed-regulator-v1_5dreg{
vin-supply = <&v24_0d>;
};

- v1_5d: fixed-regulator-v1_5d{
+ v1_5d: fixed-regulator-v1_5d {
compatible = "regulator-fixed";
regulator-name = "V1_5D";
regulator-min-microvolt = <1500000>;
--
2.34.1



2023-07-05 16:55:13

by David Lechner

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: ti: add missing space before {

On 7/5/23 9:57 AM, Krzysztof Kozlowski wrote:
> Add missing whitespace between node name/label and opening {.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Reviewed-by: David Lechner <[email protected]>



2023-07-11 14:21:36

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: ti: add missing space before {

On 16:57-20230705, Krzysztof Kozlowski wrote:
> Add missing whitespace between node name/label and opening {.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm/boot/dts/ti/davinci/da850-lego-ev3.dts | 2 +-
> arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi | 2 +-
> arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts | 8 ++++----

Tony: Could you pick this up?

Reviewed-by: Nishanth Menon <[email protected]>

> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ti/davinci/da850-lego-ev3.dts b/arch/arm/boot/dts/ti/davinci/da850-lego-ev3.dts
> index afd04a423856..17a1632a8ac1 100644
> --- a/arch/arm/boot/dts/ti/davinci/da850-lego-ev3.dts
> +++ b/arch/arm/boot/dts/ti/davinci/da850-lego-ev3.dts
> @@ -391,7 +391,7 @@ &spi1 {
> pinctrl-names = "default";
> cs-gpios = <&gpio 44 GPIO_ACTIVE_LOW>;
>
> - display@0{
> + display@0 {
> compatible = "lego,ev3-lcd";
> reg = <0>;
> spi-max-frequency = <10000000>;
> diff --git a/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi b/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
> index 8949578e62e8..2062fe561642 100644
> --- a/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
> +++ b/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
> @@ -137,7 +137,7 @@ uart01_spi2_pins: uart01-spi2-pins {
> >;
> };
>
> - dfesync_rp1_pins: dfesync-rp1-pins{
> + dfesync_rp1_pins: dfesync-rp1-pins {
> pinctrl-single,bits = <
> /* DFESYNC_RP1_SEL */
> 0x0 0x0 0x2
> diff --git a/arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts b/arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts
> index 863552393c07..edaddc7b6a5e 100644
> --- a/arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts
> +++ b/arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts
> @@ -58,7 +58,7 @@ vdd_core: fixed-regulator-vdd_core {
> vin-supply = <&vdd_corereg>;
> };
>
> - v1_8dreg: fixed-regulator-v1_8dreg{
> + v1_8dreg: fixed-regulator-v1_8dreg {
> compatible = "regulator-fixed";
> regulator-name = "V1_8DREG";
> regulator-min-microvolt = <1800000>;
> @@ -68,7 +68,7 @@ v1_8dreg: fixed-regulator-v1_8dreg{
> vin-supply = <&v24_0d>;
> };
>
> - v1_8d: fixed-regulator-v1_8d{
> + v1_8d: fixed-regulator-v1_8d {
> compatible = "regulator-fixed";
> regulator-name = "V1_8D";
> regulator-min-microvolt = <1800000>;
> @@ -78,7 +78,7 @@ v1_8d: fixed-regulator-v1_8d{
> vin-supply = <&v1_8dreg>;
> };
>
> - v1_5dreg: fixed-regulator-v1_5dreg{
> + v1_5dreg: fixed-regulator-v1_5dreg {
> compatible = "regulator-fixed";
> regulator-name = "V1_5DREG";
> regulator-min-microvolt = <1500000>;
> @@ -88,7 +88,7 @@ v1_5dreg: fixed-regulator-v1_5dreg{
> vin-supply = <&v24_0d>;
> };
>
> - v1_5d: fixed-regulator-v1_5d{
> + v1_5d: fixed-regulator-v1_5d {
> compatible = "regulator-fixed";
> regulator-name = "V1_5D";
> regulator-min-microvolt = <1500000>;
> --
> 2.34.1
>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2023-07-11 14:40:23

by Nishanth Menon

[permalink] [raw]
Subject: Re: (subset) [PATCH 1/2] ARM: dts: ti: add missing space before {

Hi Krzysztof Kozlowski,

On Wed, 05 Jul 2023 16:57:54 +0200, Krzysztof Kozlowski wrote:
> Add missing whitespace between node name/label and opening {.
>
>

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[2/2] arm64: dts: ti: add missing space before {
commit: 48a498a269c60cd3ca3de87761a1016aa7de9593

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D


2023-07-31 06:28:46

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: ti: add missing space before {

* Nishanth Menon <[email protected]> [230711 16:50]:
> On 16:57-20230705, Krzysztof Kozlowski wrote:
> > Add missing whitespace between node name/label and opening {.
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
> > ---
> > arch/arm/boot/dts/ti/davinci/da850-lego-ev3.dts | 2 +-
> > arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi | 2 +-
> > arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts | 8 ++++----
>
> Tony: Could you pick this up?
>
> Reviewed-by: Nishanth Menon <[email protected]>

Thanks applying into omap-for-v6.6/dt.

Regards,

Tony