2021-04-28 10:20:44

by Jiapeng Chong

Subject: [PATCH] net: netrom: nr_in: Remove redundant assignment to ns

Variable ns is set to 'skb->data[17]' but this value is never read as
it is overwritten or not used later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

net/netrom/nr_in.c:156:2: warning: Value stored to 'ns' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
net/netrom/nr_in.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/netrom/nr_in.c b/net/netrom/nr_in.c
index 69e5890..2f084b6 100644
--- a/net/netrom/nr_in.c
+++ b/net/netrom/nr_in.c
@@ -153,7 +153,6 @@ static int nr_state3_machine(struct sock *sk, struct sk_buff *skb, int frametype
int queued = 0;

nr = skb->data[18];
- ns = skb->data[17];

switch (frametype) {
case NR_CONNREQ:
--
1.8.3.1

2021-04-28 21:13:43

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: netrom: nr_in: Remove redundant assignment to ns

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 28 Apr 2021 17:58:05 +0800 you wrote:
> Variable ns is set to 'skb->data[17]' but this value is never read as
> it is overwritten or not used later on, hence it is a redundant
> assignment and can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> net/netrom/nr_in.c:156:2: warning: Value stored to 'ns' is never read
> [clang-analyzer-deadcode.DeadStores].
>
> [...]

Here is the summary with links:
- net: netrom: nr_in: Remove redundant assignment to ns
https://git.kernel.org/netdev/net-next/c/15c0a64bfcbc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html