2021-04-28 10:20:31

by Yang Li

Subject: [PATCH] net: tun: Remove redundant assignment to ret

Variable 'ret' is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

drivers/net/tun.c:3008:2: warning: Value stored to 'ret' is never read
[clang-analyzer-deadcode.DeadStores]

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/tun.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 4cf38be..d92c11a 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -3005,7 +3005,6 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
return open_related_ns(&net->ns, get_net_ns);
}

- ret = 0;
rtnl_lock();

tun = tun_get(tfile);
--
1.8.3.1

2021-04-28 21:11:59

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: tun: Remove redundant assignment to ret

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 28 Apr 2021 17:57:32 +0800 you wrote:
> Variable 'ret' is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> drivers/net/tun.c:3008:2: warning: Value stored to 'ret' is never read
> [clang-analyzer-deadcode.DeadStores]
>
> [...]

Here is the summary with links:
- net: tun: Remove redundant assignment to ret
https://git.kernel.org/netdev/net-next/c/808337bec736

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html