2021-04-29 01:37:36

by Yang Li

Subject: [PATCH] net: Remove redundant assignment to err

Variable 'err' is set to -ENOMEM but this value is never read as it is
overwritten with a new value later on, hence the 'If statements' and
assignments are redundantand and can be removed.

Cleans up the following clang-analyzer warning:

net/ipv6/seg6.c:126:4: warning: Value stored to 'err' is never read
[clang-analyzer-deadcode.DeadStores]

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
net/ipv6/seg6.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/net/ipv6/seg6.c b/net/ipv6/seg6.c
index d2f8138..e412817 100644
--- a/net/ipv6/seg6.c
+++ b/net/ipv6/seg6.c
@@ -122,9 +122,6 @@ static int seg6_genl_sethmac(struct sk_buff *skb, struct genl_info *info)
hinfo = seg6_hmac_info_lookup(net, hmackeyid);

if (!slen) {
- if (!hinfo)
- err = -ENOENT;
-
err = seg6_hmac_info_del(net, hmackeyid);

goto out_unlock;
--
1.8.3.1

2021-04-29 22:44:19

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: Remove redundant assignment to err

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 29 Apr 2021 09:32:36 +0800 you wrote:
> Variable 'err' is set to -ENOMEM but this value is never read as it is
> overwritten with a new value later on, hence the 'If statements' and
> assignments are redundantand and can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> net/ipv6/seg6.c:126:4: warning: Value stored to 'err' is never read
> [clang-analyzer-deadcode.DeadStores]
>
> [...]

Here is the summary with links:
- net: Remove redundant assignment to err
https://git.kernel.org/netdev/net/c/1a70f6597d5f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html