2021-04-30 09:28:45

by Jiapeng Chong

Subject: [PATCH] floppy: Remove redundant assignment to nr_sectors

Variable nr_sectors is set to zero but this value is never
read as it is overwritten later on, hence it is a redundant
assignment and can be removed.

Clean up the following clang-analyzer warning:

drivers/block/floppy.c:2333:2: warning: Value stored to 'nr_sectors' is
never read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/block/floppy.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 8a9d222..e96ad5b 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -2330,7 +2330,6 @@ static void rw_interrupt(void)
if (!drive_state[current_drive].first_read_date)
drive_state[current_drive].first_read_date = jiffies;

- nr_sectors = 0;
ssize = DIV_ROUND_UP(1 << raw_cmd->cmd[SIZECODE], 4);

if (reply_buffer[ST1] & ST1_EOC)
--
1.8.3.1

2021-04-30 09:57:12

by Denis Efremov

Subject: Re: [PATCH] floppy: Remove redundant assignment to nr_sectors

Hi,

On 4/30/21 12:26 PM, Jiapeng Chong wrote:
> Variable nr_sectors is set to zero but this value is never
> read as it is overwritten later on, hence it is a redundant
> assignment and can be removed.
>
> Clean up the following clang-analyzer warning:
>
> drivers/block/floppy.c:2333:2: warning: Value stored to 'nr_sectors' is
> never read [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Looks good, applied.
https://github.com/evdenis/linux-floppy/commit/a2d3f991fb51beb1376fb257a316e9b9e3c99737

I slightly changed the title. I guess this will go with other cleanup patches
to 5.14 release. Jens already merged 5.13 patches to master.

Thanks,
Denis

> ---
> drivers/block/floppy.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 8a9d222..e96ad5b 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -2330,7 +2330,6 @@ static void rw_interrupt(void)
> if (!drive_state[current_drive].first_read_date)
> drive_state[current_drive].first_read_date = jiffies;
>
> - nr_sectors = 0;
> ssize = DIV_ROUND_UP(1 << raw_cmd->cmd[SIZECODE], 4);
>
> if (reply_buffer[ST1] & ST1_EOC)
>