2021-04-30 03:12:49

by Jiabing Wan

[permalink] [raw]
Subject: [PATCH] net: stmmac: Remove duplicate declaration of stmmac_priv

In commit f4da56529da60 ("net: stmmac: Add support for external
trigger timestamping"), struct stmmac_priv was declared at line 507
which caused duplicate struct declarations.
Remove later duplicate declaration here.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/hwif.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.h b/drivers/net/ethernet/stmicro/stmmac/hwif.h
index 2cc91759b91f..6d5e0f2b03ce 100644
--- a/drivers/net/ethernet/stmicro/stmmac/hwif.h
+++ b/drivers/net/ethernet/stmicro/stmmac/hwif.h
@@ -564,7 +564,6 @@ struct stmmac_mode_ops {
#define stmmac_clean_desc3(__priv, __args...) \
stmmac_do_void_callback(__priv, mode, clean_desc3, __args)

-struct stmmac_priv;
struct tc_cls_u32_offload;
struct tc_cbs_qopt_offload;
struct flow_cls_offload;
--
2.25.1


2021-04-30 04:31:11

by Wong Vee Khee

[permalink] [raw]
Subject: Re: [PATCH] net: stmmac: Remove duplicate declaration of stmmac_priv

On Fri, Apr 30, 2021 at 11:10:47AM +0800, Wan Jiabing wrote:
> In commit f4da56529da60 ("net: stmmac: Add support for external
> trigger timestamping"), struct stmmac_priv was declared at line 507
> which caused duplicate struct declarations.
> Remove later duplicate declaration here.
>
> Signed-off-by: Wan Jiabing <[email protected]>

Reviewed-by: Wong Vee Khee <[email protected]>

2021-04-30 22:31:07

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] net: stmmac: Remove duplicate declaration of stmmac_priv

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 30 Apr 2021 11:10:47 +0800 you wrote:
> In commit f4da56529da60 ("net: stmmac: Add support for external
> trigger timestamping"), struct stmmac_priv was declared at line 507
> which caused duplicate struct declarations.
> Remove later duplicate declaration here.
>
> Signed-off-by: Wan Jiabing <[email protected]>
>
> [...]

Here is the summary with links:
- net: stmmac: Remove duplicate declaration of stmmac_priv
https://git.kernel.org/netdev/net/c/f18c51b6513c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html