2021-05-05 06:58:07

by Satya Priya

Subject: [PATCH V4 8/8] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp

The sc7280-idp has four PMICs, include their .dtsi files.

Signed-off-by: satya priya <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 02a14fc..704fb9a 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -12,6 +12,10 @@
#include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
#include "sc7280.dtsi"
+#include "pm7325.dtsi"
+#include "pmr735a.dtsi"
+#include "pm8350c.dtsi"
+#include "pmk8350.dtsi"

/ {
model = "Qualcomm Technologies, Inc. sc7280 IDP platform";
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-05-05 15:14:32

by Matthias Kaehlcke

Subject: Re: [PATCH V4 8/8] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp

On Wed, May 05, 2021 at 12:25:26PM +0530, satya priya wrote:
> The sc7280-idp has four PMICs, include their .dtsi files.
>
> Signed-off-by: satya priya <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> index 02a14fc..704fb9a 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> @@ -12,6 +12,10 @@
> #include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
> #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
> #include "sc7280.dtsi"
> +#include "pm7325.dtsi"
> +#include "pmr735a.dtsi"
> +#include "pm8350c.dtsi"
> +#include "pmk8350.dtsi"

Patch '[7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp'
of this series makes use of the label 'pmk8350_vadc', which doesn't exist
at that point.

A series should be organized in a way that applying only a
subset of the series (in order, starting with patch 1) doesn't
cause any build or runtime issues. To achieve this patch [7/8]
and [8/8] of this series need to be swapped.

2021-05-17 07:06:50

by Satya Priya

Subject: Re: [PATCH V4 8/8] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp

On 2021-05-05 20:27, Matthias Kaehlcke wrote:
> On Wed, May 05, 2021 at 12:25:26PM +0530, satya priya wrote:
>> The sc7280-idp has four PMICs, include their .dtsi files.
>>
>> Signed-off-by: satya priya <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> index 02a14fc..704fb9a 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> @@ -12,6 +12,10 @@
>> #include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
>> #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
>> #include "sc7280.dtsi"
>> +#include "pm7325.dtsi"
>> +#include "pmr735a.dtsi"
>> +#include "pm8350c.dtsi"
>> +#include "pmk8350.dtsi"
>
> Patch '[7/8] arm64: dts: qcom: sc7280: Add channel nodes for
> sc7280-idp'
> of this series makes use of the label 'pmk8350_vadc', which doesn't
> exist
> at that point.
>
> A series should be organized in a way that applying only a
> subset of the series (in order, starting with patch 1) doesn't
> cause any build or runtime issues. To achieve this patch [7/8]
> and [8/8] of this series need to be swapped.

Okay, I will re-arrange the series and resend v4.

Thanks,
Satya Priya