2021-05-08 10:05:41

by Yang Li

Subject: [PATCH] neighbour: Remove redundant initialization of 'bucket'

Integer variable 'bucket' is being initialized however
this value is never read as 'bucket' is assigned zero
in for statement. Remove the redundant assignment.

Cleans up clang warning:

net/core/neighbour.c:3144:6: warning: Value stored to 'bucket' during
its initialization is never read [clang-analyzer-deadcode.DeadStores]

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
net/core/neighbour.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 98f20efb..2b2f333 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -3141,7 +3141,7 @@ static struct pneigh_entry *pneigh_get_first(struct seq_file *seq)
struct net *net = seq_file_net(seq);
struct neigh_table *tbl = state->tbl;
struct pneigh_entry *pn = NULL;
- int bucket = state->bucket;
+ int bucket;

state->flags |= NEIGH_SEQ_IS_PNEIGH;
for (bucket = 0; bucket <= PNEIGH_HASHMASK; bucket++) {
--
1.8.3.1

2021-05-10 21:33:06

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] neighbour: Remove redundant initialization of 'bucket'

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 8 May 2021 18:03:05 +0800 you wrote:
> Integer variable 'bucket' is being initialized however
> this value is never read as 'bucket' is assigned zero
> in for statement. Remove the redundant assignment.
>
> Cleans up clang warning:
>
> net/core/neighbour.c:3144:6: warning: Value stored to 'bucket' during
> its initialization is never read [clang-analyzer-deadcode.DeadStores]
>
> [...]

Here is the summary with links:
- neighbour: Remove redundant initialization of 'bucket'
https://git.kernel.org/netdev/net-next/c/48de7c0c1c92

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html