2021-03-29 09:19:39

by Liu Shixin

[permalink] [raw]
Subject: [PATCH -next] scsi: megaraid_sas: Use DEFINE_SPINLOCK() for spinlock

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Signed-off-by: Shixin Liu <[email protected]>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 4d4e9dbe5193..8ed347eebf07 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -213,7 +213,7 @@ static bool support_nvme_encapsulation;
static bool support_pci_lane_margining;

/* define lock for aen poll */
-static spinlock_t poll_aen_lock;
+static DEFINE_SPINLOCK(poll_aen_lock);

extern struct dentry *megasas_debugfs_root;
extern int megasas_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num);
@@ -8934,8 +8934,6 @@ static int __init megasas_init(void)
*/
pr_info("megasas: %s\n", MEGASAS_VERSION);

- spin_lock_init(&poll_aen_lock);
-
support_poll_for_event = 2;
support_device_change = 1;
support_nvme_encapsulation = true;
--
2.25.1


2021-04-15 00:03:52

by Sumit Saxena

[permalink] [raw]
Subject: Re: [PATCH -next] scsi: megaraid_sas: Use DEFINE_SPINLOCK() for spinlock

On Mon, Mar 29, 2021 at 2:45 PM Shixin Liu <[email protected]> wrote:
>
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
Acked-by: Sumit Saxena <[email protected]>
>
> Signed-off-by: Shixin Liu <[email protected]>
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 4d4e9dbe5193..8ed347eebf07 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -213,7 +213,7 @@ static bool support_nvme_encapsulation;
> static bool support_pci_lane_margining;
>
> /* define lock for aen poll */
> -static spinlock_t poll_aen_lock;
> +static DEFINE_SPINLOCK(poll_aen_lock);
>
> extern struct dentry *megasas_debugfs_root;
> extern int megasas_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num);
> @@ -8934,8 +8934,6 @@ static int __init megasas_init(void)
> */
> pr_info("megasas: %s\n", MEGASAS_VERSION);
>
> - spin_lock_init(&poll_aen_lock);
> -
> support_poll_for_event = 2;
> support_device_change = 1;
> support_nvme_encapsulation = true;
> --
> 2.25.1
>

Attachments:
smime.p7s (4.11 kB)
S/MIME Cryptographic Signature

2021-05-11 03:28:18

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH -next] scsi: megaraid_sas: Use DEFINE_SPINLOCK() for spinlock

On Mon, 29 Mar 2021 17:45:32 +0800, Shixin Liu wrote:

> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: megaraid_sas: Use DEFINE_SPINLOCK() for spinlock
https://git.kernel.org/mkp/scsi/c/311e87b70913

--
Martin K. Petersen Oracle Linux Engineering