2021-05-11 03:32:05

by Zou Wei

Subject: [PATCH -next] media: mt9v111: Add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/media/i2c/mt9v111.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
index 97c7527..f16e632 100644
--- a/drivers/media/i2c/mt9v111.c
+++ b/drivers/media/i2c/mt9v111.c
@@ -1260,6 +1260,7 @@ static const struct of_device_id mt9v111_of_match[] = {
{ .compatible = "aptina,mt9v111", },
{ /* sentinel */ },
};
+MODULE_DEVICE_TABLE(of, mt9v111_of_match);

static struct i2c_driver mt9v111_driver = {
.driver = {
--
2.6.2

2021-06-14 07:50:32

by jacopo mondi

Subject: Re: [PATCH -next] media: mt9v111: Add missing MODULE_DEVICE_TABLE

Hello Zou

On Tue, May 11, 2021 at 11:47:36AM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Sorry for getting late on this

Acked-by: Jacopo Mondi <[email protected]>

Thanks
j

> ---
> drivers/media/i2c/mt9v111.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
> index 97c7527..f16e632 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -1260,6 +1260,7 @@ static const struct of_device_id mt9v111_of_match[] = {
> { .compatible = "aptina,mt9v111", },
> { /* sentinel */ },
> };
> +MODULE_DEVICE_TABLE(of, mt9v111_of_match);
>
> static struct i2c_driver mt9v111_driver = {
> .driver = {
> --
> 2.6.2
>