2021-05-11 06:26:56

by Zou Wei

Subject: [PATCH -next] drivers/perf: Remove redundant dev_err call in tx2_uncore_pmu_init_dev()

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/perf/thunderx2_pmu.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/perf/thunderx2_pmu.c b/drivers/perf/thunderx2_pmu.c
index 06a6d56..9e8f55a 100644
--- a/drivers/perf/thunderx2_pmu.c
+++ b/drivers/perf/thunderx2_pmu.c
@@ -818,7 +818,6 @@ static struct tx2_uncore_pmu *tx2_uncore_pmu_init_dev(struct device *dev,

base = devm_ioremap_resource(dev, &res);
if (IS_ERR(base)) {
- dev_err(dev, "PMU type %d: Fail to map resource\n", type);
return NULL;
}

--
2.6.2

2021-05-25 19:02:47

by Will Deacon

Subject: Re: [PATCH -next] drivers/perf: Remove redundant dev_err call in tx2_uncore_pmu_init_dev()

On Tue, 11 May 2021 14:42:44 +0800, Zou Wei wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Applied to will (for-next/perf), thanks!

[1/1] drivers/perf: Remove redundant dev_err call in tx2_uncore_pmu_init_dev()
https://git.kernel.org/will/c/bf2367aaed73

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev