There is a return above the break.
The break here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing <[email protected]>
---
arch/arm/mach-s3c/mach-rx1950.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-s3c/mach-rx1950.c b/arch/arm/mach-s3c/mach-rx1950.c
index 6e19add158a9..9da94686001a 100644
--- a/arch/arm/mach-s3c/mach-rx1950.c
+++ b/arch/arm/mach-s3c/mach-rx1950.c
@@ -271,7 +271,6 @@ static int rx1950_led_blink_set(struct gpio_desc *desc, int state,
break;
default:
return -EINVAL;
- break;
}
if (delay_on && delay_off && !*delay_on && !*delay_off)
--
2.25.1
On 09/04/2021 08:49, Wan Jiabing wrote:
> There is a return above the break.
> The break here is unnecessary. Remove it.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> arch/arm/mach-s3c/mach-rx1950.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks, looks good but I do not plan another pull request in current
cycle, so I will take it after the merge window.
Best regards,
Krzysztof
On Fri, 9 Apr 2021 14:49:20 +0800, Wan Jiabing wrote:
> There is a return above the break.
> The break here is unnecessary. Remove it.
Applied, thanks!
[1/1] arm: mach-s3c: Remove unnecessary break
commit: 0de0b04c83430ee913c9683369b7059e04e106cb
Best regards,
--
Krzysztof Kozlowski <[email protected]>