2021-05-12 03:16:26

by Zou Wei

[permalink] [raw]
Subject: [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/net/mdio/mdio-aspeed.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio-aspeed.c
index cad8205..bb9933f 100644
--- a/drivers/net/mdio/mdio-aspeed.c
+++ b/drivers/net/mdio/mdio-aspeed.c
@@ -141,6 +141,7 @@ static const struct of_device_id aspeed_mdio_of_match[] = {
{ .compatible = "aspeed,ast2600-mdio", },
{ },
};
+MODULE_DEVICE_TABLE(of, aspeed_mdio_of_match);

static struct platform_driver aspeed_mdio_driver = {
.driver = {
--
2.6.2


2021-05-12 06:35:50

by Joel Stanley

[permalink] [raw]
Subject: Re: [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE

On Wed, 12 May 2021 at 03:13, Zou Wei <[email protected]> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Fixes: f160e99462c6 ("net: phy: Add mdio-aspeed")
Acked-by: Joel Stanley <[email protected]>

Thanks for the patch.

2021-05-12 13:15:00

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE

On Wed, May 12, 2021 at 11:30:04AM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.

Please make the subject line more specific. There are a number of MDIO
bus drivers in the kernel. Adding "aspeed:" would make it clear which
one you are changing.

Andrew