2021-05-12 03:46:04

by Zou Wei

[permalink] [raw]
Subject: [PATCH -next] ARM: tegra: Add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/amba/tegra-ahb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c
index 0b2c20f..a0af8ed 100644
--- a/drivers/amba/tegra-ahb.c
+++ b/drivers/amba/tegra-ahb.c
@@ -272,6 +272,7 @@ static const struct of_device_id tegra_ahb_of_match[] = {
{ .compatible = "nvidia,tegra20-ahb", },
{},
};
+MODULE_DEVICE_TABLE(of, tegra_ahb_of_match);

static struct platform_driver tegra_ahb_driver = {
.probe = tegra_ahb_probe,
--
2.6.2


2021-06-01 17:04:24

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH -next] ARM: tegra: Add missing MODULE_DEVICE_TABLE

On Wed, May 12, 2021 at 12:01:29PM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/amba/tegra-ahb.c | 1 +
> 1 file changed, 1 insertion(+)

This driver cannot be built as an external module, so the device table
doesn't make sense.

Thierry


Attachments:
(No filename) (513.00 B)
signature.asc (849.00 B)
Download all attachments