2021-05-13 11:57:05

by Jiapeng Chong

Subject: [PATCH] xtensa: Fix duplicate included linux/unaligned/generic.h

Clean up the following includecheck warning:

./arch/xtensa/include/asm/unaligned.h: linux/unaligned/generic.h is
included more than once.

No functional change.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
arch/xtensa/include/asm/unaligned.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/xtensa/include/asm/unaligned.h b/arch/xtensa/include/asm/unaligned.h
index 8e7ed04..c8838d9 100644
--- a/arch/xtensa/include/asm/unaligned.h
+++ b/arch/xtensa/include/asm/unaligned.h
@@ -15,15 +15,15 @@
#ifdef __LITTLE_ENDIAN
# include <linux/unaligned/le_struct.h>
# include <linux/unaligned/be_byteshift.h>
-# include <linux/unaligned/generic.h>
# define get_unaligned __get_unaligned_le
# define put_unaligned __put_unaligned_le
#else
# include <linux/unaligned/be_struct.h>
# include <linux/unaligned/le_byteshift.h>
-# include <linux/unaligned/generic.h>
# define get_unaligned __get_unaligned_be
# define put_unaligned __put_unaligned_be
#endif

+# include <linux/unaligned/generic.h>
+
#endif /* _ASM_XTENSA_UNALIGNED_H */
--
1.8.3.1

2021-05-13 23:30:31

by Max Filippov

Subject: Re: [PATCH] xtensa: Fix duplicate included linux/unaligned/generic.h

Hi Jiapeng,

On Thu, May 13, 2021 at 4:07 AM Jiapeng Chong
<[email protected]> wrote:
>
> Clean up the following includecheck warning:
>
> ./arch/xtensa/include/asm/unaligned.h: linux/unaligned/generic.h is
> included more than once.
>
> No functional change.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> arch/xtensa/include/asm/unaligned.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

There's a patch series from Arnd Bergman that reworks unaligned
access posted here:
https://lore.kernel.org/lkml/[email protected]/
resulting in removal of this file. I don't think it's worth doing this cleanup
in the meantime.

--
Thanks.
-- Max