2021-05-13 20:24:49

by Tian Tao

Subject: [PATCH] mfd: max8907: move to use request_irq by IRQF_NO_AUTOEN flag

This change is just to simplify the code, no actual functional changes.

Signed-off-by: Tian Tao <[email protected]>
---
drivers/mfd/max8907.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
index d44baaf..40e70ab 100644
--- a/drivers/mfd/max8907.c
+++ b/drivers/mfd/max8907.c
@@ -228,11 +228,9 @@ static int max8907_i2c_probe(struct i2c_client *i2c,
goto err_regmap_rtc;
}

- irq_set_status_flags(max8907->i2c_gen->irq, IRQ_NOAUTOEN);
-
ret = regmap_add_irq_chip(max8907->regmap_gen, max8907->i2c_gen->irq,
- IRQF_ONESHOT | IRQF_SHARED, -1,
- &max8907_chg_irq_chip,
+ IRQF_ONESHOT | IRQF_SHARED | IRQF_NO_AUTOEN,
+ -1, &max8907_chg_irq_chip,
&max8907->irqc_chg);
if (ret != 0) {
dev_err(&i2c->dev, "failed to add chg irq chip: %d\n", ret);
--
2.7.4

2021-05-19 20:09:52

by Lee Jones

Subject: Re: [PATCH] mfd: max8907: move to use request_irq by IRQF_NO_AUTOEN flag

On Thu, 13 May 2021, Tian Tao wrote:

> This change is just to simplify the code, no actual functional changes.
>
> Signed-off-by: Tian Tao <[email protected]>
> ---
> drivers/mfd/max8907.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog