2021-05-17 03:30:22

by Tiezhu Yang

Subject: [PATCH v4 1/2] samples/kprobes: Fix typo in handler_fault()

Fix a defective format in handler_fault() ending with an 'n' that
should be '\n'.

Fixes: 804defea1c02 ("Kprobes: move kprobe examples to samples/")
Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Tiezhu Yang <[email protected]>
---
samples/kprobes/kprobe_example.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
index c495664..d77a546 100644
--- a/samples/kprobes/kprobe_example.c
+++ b/samples/kprobes/kprobe_example.c
@@ -101,7 +101,7 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs,
*/
static int handler_fault(struct kprobe *p, struct pt_regs *regs, int trapnr)
{
- pr_info("fault_handler: p->addr = 0x%p, trap #%dn", p->addr, trapnr);
+ pr_info("fault_handler: p->addr = 0x%p, trap #%d\n", p->addr, trapnr);
/* Return 0 because we don't handle the fault. */
return 0;
}
--
2.1.0

2021-05-17 07:07:22

by Masami Hiramatsu

Subject: Re: [PATCH v4 1/2] samples/kprobes: Fix typo in handler_fault()

On Mon, 17 May 2021 10:21:22 +0800
Tiezhu Yang <[email protected]> wrote:

> Fix a defective format in handler_fault() ending with an 'n' that
> should be '\n'.
>
> Fixes: 804defea1c02 ("Kprobes: move kprobe examples to samples/")
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Tiezhu Yang <[email protected]>

Looks good to me.

Acked-by: Masami Hiramatsu <[email protected]>

Thank you!

> ---
> samples/kprobes/kprobe_example.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index c495664..d77a546 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -101,7 +101,7 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs,
> */
> static int handler_fault(struct kprobe *p, struct pt_regs *regs, int trapnr)
> {
> - pr_info("fault_handler: p->addr = 0x%p, trap #%dn", p->addr, trapnr);
> + pr_info("fault_handler: p->addr = 0x%p, trap #%d\n", p->addr, trapnr);
> /* Return 0 because we don't handle the fault. */
> return 0;
> }
> --
> 2.1.0
>


--
Masami Hiramatsu <[email protected]>