2021-05-17 10:18:50

by Jiapeng Chong

Subject: [PATCH] net/packet: Remove redundant assignment to ret

Variable ret is set to '0' or '-EBUSY', but this value is never read
as it is not used later on, hence it is a redundant assignment and
can be removed.

Clean up the following clang-analyzer warning:

net/packet/af_packet.c:3936:4: warning: Value stored to 'ret' is never
read [clang-analyzer-deadcode.DeadStores].

net/packet/af_packet.c:3933:4: warning: Value stored to 'ret' is never
read [clang-analyzer-deadcode.DeadStores].

No functional change.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
net/packet/af_packet.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index ae906eb..71dd6b9 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -3929,12 +3929,9 @@ static void packet_flush_mclist(struct sock *sk)
return -EFAULT;

lock_sock(sk);
- if (po->rx_ring.pg_vec || po->tx_ring.pg_vec) {
- ret = -EBUSY;
- } else {
+ if (!po->rx_ring.pg_vec && !po->tx_ring.pg_vec)
po->tp_tx_has_off = !!val;
- ret = 0;
- }
+
release_sock(sk);
return 0;
}
--
1.8.3.1

2021-05-19 09:06:00

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net/packet: Remove redundant assignment to ret

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 17 May 2021 18:15:25 +0800 you wrote:
> Variable ret is set to '0' or '-EBUSY', but this value is never read
> as it is not used later on, hence it is a redundant assignment and
> can be removed.
>
> Clean up the following clang-analyzer warning:
>
> net/packet/af_packet.c:3936:4: warning: Value stored to 'ret' is never
> read [clang-analyzer-deadcode.DeadStores].
>
> [...]

Here is the summary with links:
- net/packet: Remove redundant assignment to ret
https://git.kernel.org/netdev/net-next/c/25c55b38d85b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html