2021-05-19 08:05:40

by Siddharth Gupta

Subject: [PATCH 2/3] remoteproc: core: Move validate before device add

We can validate whether the remoteproc is correctly setup before
calling making the cdev_add and device_add calls. This saves us
the trouble of cleaning up later on.

Signed-off-by: Siddharth Gupta <[email protected]>
---
drivers/remoteproc/remoteproc_core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 562355a..45d09bf 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -2316,16 +2316,16 @@ int rproc_add(struct rproc *rproc)
struct device *dev = &rproc->dev;
int ret;

- /* add char device for this remoteproc */
- ret = rproc_char_device_add(rproc);
+ ret = rproc_validate(rproc);
if (ret < 0)
return ret;

- ret = device_add(dev);
+ /* add char device for this remoteproc */
+ ret = rproc_char_device_add(rproc);
if (ret < 0)
return ret;

- ret = rproc_validate(rproc);
+ ret = device_add(dev);
if (ret < 0)
return ret;

--
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2021-05-28 07:22:13

by Bjorn Andersson

Subject: Re: [PATCH 2/3] remoteproc: core: Move validate before device add

On Mon 17 May 15:45 CDT 2021, Siddharth Gupta wrote:

> We can validate whether the remoteproc is correctly setup before
> calling making the cdev_add and device_add calls. This saves us
> the trouble of cleaning up later on.
>

Reviewed-by: Bjorn Andersson <[email protected]>

> Signed-off-by: Siddharth Gupta <[email protected]>
> ---
> drivers/remoteproc/remoteproc_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 562355a..45d09bf 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -2316,16 +2316,16 @@ int rproc_add(struct rproc *rproc)
> struct device *dev = &rproc->dev;
> int ret;
>
> - /* add char device for this remoteproc */
> - ret = rproc_char_device_add(rproc);
> + ret = rproc_validate(rproc);
> if (ret < 0)
> return ret;
>
> - ret = device_add(dev);
> + /* add char device for this remoteproc */
> + ret = rproc_char_device_add(rproc);
> if (ret < 0)
> return ret;
>
> - ret = rproc_validate(rproc);
> + ret = device_add(dev);
> if (ret < 0)
> return ret;
>
> --
> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>