2021-05-19 17:06:11

by Tiezhu Yang

Subject: [PATCH bpf-next] bpf, arm64: Remove redundant switch case about BPF_DIV and BPF_MOD

After commit 96a71005bdcb ("bpf, arm64: remove obsolete exception handling
from div/mod"), there is no need to check twice about BPF_DIV and BPF_MOD,
remove the redundant switch case.

Signed-off-by: Tiezhu Yang <[email protected]>
---
arch/arm64/net/bpf_jit_comp.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
index 9785026..be873a7 100644
--- a/arch/arm64/net/bpf_jit_comp.c
+++ b/arch/arm64/net/bpf_jit_comp.c
@@ -485,17 +485,12 @@ static int build_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,
break;
case BPF_ALU | BPF_DIV | BPF_X:
case BPF_ALU64 | BPF_DIV | BPF_X:
+ emit(A64_UDIV(is64, dst, dst, src), ctx);
+ break;
case BPF_ALU | BPF_MOD | BPF_X:
case BPF_ALU64 | BPF_MOD | BPF_X:
- switch (BPF_OP(code)) {
- case BPF_DIV:
- emit(A64_UDIV(is64, dst, dst, src), ctx);
- break;
- case BPF_MOD:
- emit(A64_UDIV(is64, tmp, dst, src), ctx);
- emit(A64_MSUB(is64, dst, dst, tmp, src), ctx);
- break;
- }
+ emit(A64_UDIV(is64, tmp, dst, src), ctx);
+ emit(A64_MSUB(is64, dst, dst, tmp, src), ctx);
break;
case BPF_ALU | BPF_LSH | BPF_X:
case BPF_ALU64 | BPF_LSH | BPF_X:
--
2.1.0

2021-05-19 18:18:08

by patchwork-bot+netdevbpf

Subject: Re: [PATCH bpf-next] bpf, arm64: Remove redundant switch case about BPF_DIV and BPF_MOD

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Tue, 18 May 2021 16:56:10 +0800 you wrote:
> After commit 96a71005bdcb ("bpf, arm64: remove obsolete exception handling
> from div/mod"), there is no need to check twice about BPF_DIV and BPF_MOD,
> remove the redundant switch case.
>
> Signed-off-by: Tiezhu Yang <[email protected]>
> ---
> arch/arm64/net/bpf_jit_comp.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)

Here is the summary with links:
- [bpf-next] bpf, arm64: Remove redundant switch case about BPF_DIV and BPF_MOD
https://git.kernel.org/bpf/bpf-next/c/119220d81258

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html