2021-05-19 19:25:40

by Dikshita Agarwal

Subject: [PATCH 4/7] media: venus: hfi: Skip AON register programming for V6 1pipe

AON register programming is used to set NOC to low
power mode during V6 power off sequence. However
AON register memory map is not applicable to 1pipe,
hence skipping AON register programming.

Co-developed-by: Mansur Alisha Shaik <[email protected]>
Co-developed-by: Vikash Garodia <[email protected]>
Signed-off-by: Dikshita Agarwal <[email protected]>
---
drivers/media/platform/qcom/venus/hfi_venus.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c
index ce98c52..3a75a27 100644
--- a/drivers/media/platform/qcom/venus/hfi_venus.c
+++ b/drivers/media/platform/qcom/venus/hfi_venus.c
@@ -551,6 +551,9 @@ static int venus_halt_axi(struct venus_hfi_device *hdev)
if (IS_V6(hdev->core)) {
writel(0x3, cpu_cs_base + CPU_CS_X2RPMH_V6);

+ if (hdev->core->res->num_vpp_pipes == 1)
+ goto skip_aon_mvp_noc;
+
writel(0x1, aon_base + AON_WRAPPER_MVP_NOC_LPI_CONTROL);
ret = readl_poll_timeout(aon_base + AON_WRAPPER_MVP_NOC_LPI_STATUS,
val,
@@ -560,6 +563,7 @@ static int venus_halt_axi(struct venus_hfi_device *hdev)
if (ret)
return -ETIMEDOUT;

+skip_aon_mvp_noc:
mask_val = (BIT(2) | BIT(1) | BIT(0));
writel(mask_val, wrapper_base + WRAPPER_DEBUG_BRIDGE_LPI_CONTROL_V6);

--
2.7.4

2021-05-31 11:21:04

by Stanimir Varbanov

Subject: Re: [PATCH 4/7] media: venus: hfi: Skip AON register programming for V6 1pipe

On 5/19/21 12:36 PM, Dikshita Agarwal wrote:
> AON register programming is used to set NOC to low
> power mode during V6 power off sequence. However
> AON register memory map is not applicable to 1pipe,
> hence skipping AON register programming.
>
> Co-developed-by: Mansur Alisha Shaik <[email protected]>
> Co-developed-by: Vikash Garodia <[email protected]>
> Signed-off-by: Dikshita Agarwal <[email protected]>
> ---
> drivers/media/platform/qcom/venus/hfi_venus.c | 4 ++++
> 1 file changed, 4 insertions(+)
>

Acked-by: Stanimir Varbanov <[email protected]>

--
regards,
Stan