2021-05-22 10:11:39

by fanghao (A)

Subject: [PATCH RESEND] Input: misc - use the correct HiSilicon copyright

s/Hisilicon/HiSilicon/g.
It should use capital S, according to
https://www.hisilicon.com/en.

Signed-off-by: Hao Fang <[email protected]>
---
drivers/input/misc/hisi_powerkey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/misc/hisi_powerkey.c b/drivers/input/misc/hisi_powerkey.c
index d3c293a..54cbfdf 100644
--- a/drivers/input/misc/hisi_powerkey.c
+++ b/drivers/input/misc/hisi_powerkey.c
@@ -1,7 +1,7 @@
/*
* Hisilicon PMIC powerkey driver
*
- * Copyright (C) 2013 Hisilicon Ltd.
+ * Copyright (C) 2013 HiSilicon Ltd.
* Copyright (C) 2015, 2016 Linaro Ltd.
*
* This file is subject to the terms and conditions of the GNU General
--
2.8.1

2021-05-24 02:58:53

by Dmitry Torokhov

Subject: Re: [PATCH RESEND] Input: misc - use the correct HiSilicon copyright

Hi Hao,

On Sat, May 22, 2021 at 06:06:27PM +0800, Hao Fang wrote:
> s/Hisilicon/HiSilicon/g.
> It should use capital S, according to
> https://www.hisilicon.com/en.
>
> Signed-off-by: Hao Fang <[email protected]>
> ---
> drivers/input/misc/hisi_powerkey.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/hisi_powerkey.c b/drivers/input/misc/hisi_powerkey.c
> index d3c293a..54cbfdf 100644
> --- a/drivers/input/misc/hisi_powerkey.c
> +++ b/drivers/input/misc/hisi_powerkey.c
> @@ -1,7 +1,7 @@
> /*
> * Hisilicon PMIC powerkey driver
> *
> - * Copyright (C) 2013 Hisilicon Ltd.
> + * Copyright (C) 2013 HiSilicon Ltd.

I see there are various versions of "Hisilicon" in copyright notices. I
do not know if capitalization here matters and which form is correct.
If this is important I'd rather HiSilicon folks submitted such
patch(es).

Thanks.

--
Dmitry

2021-05-24 14:01:08

by fanghao (A)

Subject: Re: [PATCH RESEND] Input: misc - use the correct HiSilicon copyright

On 2021/5/24 10:57, Dmitry Torokhov wrote:
> Hi Hao,
>
> On Sat, May 22, 2021 at 06:06:27PM +0800, Hao Fang wrote:
>> s/Hisilicon/HiSilicon/g.
>> It should use capital S, according to
>> https://www.hisilicon.com/en.
>>
>> Signed-off-by: Hao Fang <[email protected]>
>> ---
>> drivers/input/misc/hisi_powerkey.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/misc/hisi_powerkey.c b/drivers/input/misc/hisi_powerkey.c
>> index d3c293a..54cbfdf 100644
>> --- a/drivers/input/misc/hisi_powerkey.c
>> +++ b/drivers/input/misc/hisi_powerkey.c
>> @@ -1,7 +1,7 @@
>> /*
>> * Hisilicon PMIC powerkey driver
>> *
>> - * Copyright (C) 2013 Hisilicon Ltd.
>> + * Copyright (C) 2013 HiSilicon Ltd.
>
> I see there are various versions of "Hisilicon" in copyright notices. I
> do not know if capitalization here matters and which form is correct.
> If this is important I'd rather HiSilicon folks submitted such
> patch(es).
>

Xuezhiliang, can you help to review this patch and add an Acked-by? Or you can resubmit it.
I found out you're the author of this driver, maybe you changed your email address.

Thanks.
Hao

>