2021-05-22 10:30:19

by fanghao (A)

Subject: [PATCH] scsi: hisi_sas: Use the correct HiSilicon copyright

s/Hisilicon/HiSilicon/.
It should use capital S, according to the official website
https://www.hisilicon.com/en.

Signed-off-by: Hao Fang <[email protected]>
---
drivers/scsi/hisi_sas/hisi_sas.h | 2 +-
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 2 +-
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 2 +-
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h
index cf879cc..84ceddc 100644
--- a/drivers/scsi/hisi_sas/hisi_sas.h
+++ b/drivers/scsi/hisi_sas/hisi_sas.h
@@ -1,7 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
* Copyright (c) 2015 Linaro Ltd.
- * Copyright (c) 2015 Hisilicon Limited.
+ * Copyright (c) 2015 HiSilicon Limited.
*/

#ifndef _HISI_SAS_H_
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 5a20407..acc3e13 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (c) 2015 Linaro Ltd.
- * Copyright (c) 2015 Hisilicon Limited.
+ * Copyright (c) 2015 HiSilicon Limited.
*/

#include "hisi_sas.h"
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
index 3e359ac..39588b0 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (c) 2015 Linaro Ltd.
- * Copyright (c) 2015 Hisilicon Limited.
+ * Copyright (c) 2015 HiSilicon Limited.
*/

#include "hisi_sas.h"
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
index 46f60fc..454bec9 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (c) 2016 Linaro Ltd.
- * Copyright (c) 2016 Hisilicon Limited.
+ * Copyright (c) 2016 HiSilicon Limited.
*/

#include "hisi_sas.h"
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
index 499c770..7a1858f 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
- * Copyright (c) 2017 Hisilicon Limited.
+ * Copyright (c) 2017 HiSilicon Limited.
*/

#include "hisi_sas.h"
--
2.8.1

2021-05-22 14:58:01

by James Bottomley

Subject: Re: [PATCH] scsi: hisi_sas: Use the correct HiSilicon copyright

On Sat, 2021-05-22 at 18:24 +0800, Hao Fang wrote:
> s/Hisilicon/HiSilicon/.
> It should use capital S, according to the official website
> https://www.hisilicon.com/en.

You can't do this. The strict terms of the GPL require us to preserve
intact all notices referring to copyright and licences. If hisilicon
truly did make a mistake when they added their original copyright
notices, *they* may submit a patch to correct it, but you can't correct
it for them without their permission just because you think they got it
wrong.

James

2021-05-24 13:53:06

by fanghao (A)

Subject: Re: [PATCH] scsi: hisi_sas: Use the correct HiSilicon copyright

On 2021/5/22 22:56, James Bottomley wrote:
> On Sat, 2021-05-22 at 18:24 +0800, Hao Fang wrote:
>> s/Hisilicon/HiSilicon/.
>> It should use capital S, according to the official website
>> https://www.hisilicon.com/en.
>
> You can't do this. The strict terms of the GPL require us to preserve
> intact all notices referring to copyright and licences. If hisilicon
> truly did make a mistake when they added their original copyright
> notices, *they* may submit a patch to correct it, but you can't correct
> it for them without their permission just because you think they got it
> wrong.
>

John, can you help to review this patch and add an Acked-by? Or you can resubmit it.

Thanks.

Hao
>
>
>
> .
>