2021-05-25 07:16:11

by Wu Bo

Subject: [PATCH] fuse: use DIV_ROUND_UP helper macro for calculations

From: Wu Bo <[email protected]>

Replace open coded divisor calculations with the DIV_ROUND_UP kernel
macro for better readability.

Signed-off-by: Wu Bo <[email protected]>
---
fs/fuse/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 09ef2a4..62443eb 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1405,7 +1405,7 @@ static int fuse_get_user_pages(struct fuse_args_pages *ap, struct iov_iter *ii,
nbytes += ret;

ret += start;
- npages = (ret + PAGE_SIZE - 1) / PAGE_SIZE;
+ npages = DIV_ROUND_UP(ret, PAGE_SIZE);

ap->descs[ap->num_pages].offset = start;
fuse_page_descs_length_init(ap->descs, ap->num_pages, npages);
--
1.8.3.1

2021-06-01 06:15:40

by Wu Bo

Subject: Re: [PATCH] fuse: use DIV_ROUND_UP helper macro for calculations

ping ...

On 2021/5/25 15:40, Wu Bo wrote:
> From: Wu Bo <[email protected]>
>
> Replace open coded divisor calculations with the DIV_ROUND_UP kernel
> macro for better readability.
>
> Signed-off-by: Wu Bo <[email protected]>
> ---
> fs/fuse/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 09ef2a4..62443eb 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -1405,7 +1405,7 @@ static int fuse_get_user_pages(struct fuse_args_pages *ap, struct iov_iter *ii,
> nbytes += ret;
>
> ret += start;
> - npages = (ret + PAGE_SIZE - 1) / PAGE_SIZE;
> + npages = DIV_ROUND_UP(ret, PAGE_SIZE);
>
> ap->descs[ap->num_pages].offset = start;
> fuse_page_descs_length_init(ap->descs, ap->num_pages, npages);
>

2021-06-21 08:33:45

by Miklos Szeredi

Subject: Re: [PATCH] fuse: use DIV_ROUND_UP helper macro for calculations

On Tue, 25 May 2021 at 09:15, Wu Bo <[email protected]> wrote:
>
> From: Wu Bo <[email protected]>
>
> Replace open coded divisor calculations with the DIV_ROUND_UP kernel
> macro for better readability.

Applied, thanks.

Miklos